Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1797593003: Stop reporting use of deprecated members from within deprecated members (issue 25966) (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop reporting use of deprecated members from within deprecated members (issue 25966) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d779eee74ce77c5097b3c2950ec666e2a2f67aae

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -24 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 8 chunks +44 lines, -16 lines 1 comment Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 7 chunks +63 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-13 18:38:12 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-13 20:40:48 UTC) #3
scheglov
LGTM https://codereview.chromium.org/1797593003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1797593003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode150 pkg/analyzer/lib/src/generated/resolver.dart:150: inDeprecatedMember = true; This could be a single ...
4 years, 9 months ago (2016-03-13 20:41:23 UTC) #4
Brian Wilkerson
4 years, 9 months ago (2016-03-13 20:57:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d779eee74ce77c5097b3c2950ec666e2a2f67aae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698