Stop reporting use of deprecated members from within deprecated members (issue 25966)

pkg/analyzer/test/generated/non_hint_code_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.non_hint_code_test;
 
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 
 import '../reflective_tests.dart';
@@ skipping 140 matching lines @@
     Source source = addSource(r'''
 const bool DEBUG = true;
 f() {
   bool b = DEBUG || true;
 }''');
     computeLibrarySourceErrors(source);
     assertNoErrors(source);
     verify([source]);
   }
 
-  void test_deprecatedAnnotationUse_classWithConstructor() {
+  void test_deprecatedMemberUse_inDeprecatedClass() {
     Source source = addSource(r'''
 @deprecated
+f() {}
+
+@deprecated
 class C {
-  C();
+  m() {
+    f();
+  }
 }
 ''');
     computeLibrarySourceErrors(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
+  void test_deprecatedMemberUse_inDeprecatedFunction() {
+    Source source = addSource(r'''
+@deprecated
+f() {}
+
+@deprecated
+g() {
+  f();
+}
+''');
+    computeLibrarySourceErrors(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
+  void test_deprecatedMemberUse_inDeprecatedMethod() {
+    Source source = addSource(r'''
+@deprecated
+f() {}
+
+class C {
+  @deprecated
+  m() {
+    f();
+  }
+}
+''');
+    computeLibrarySourceErrors(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
+  void test_deprecatedMemberUse_inDeprecatedMethod_inDeprecatedClass() {
+    Source source = addSource(r'''
+@deprecated
+f() {}
+
+@deprecated
+class C {
+  @deprecated
+  m() {
+    f();
+  }
+}
+''');
+    computeLibrarySourceErrors(source);
     assertNoErrors(source);
     verify([source]);
   }
 
   void test_divisionOptimization() {
     Source source = addSource(r'''
 f(int x, int y) {
   var v = x / y.toInt();
 }''');
     computeLibrarySourceErrors(source);
@@ skipping 909 matching lines @@
     assertErrors(source, [
       CompileTimeErrorCode.URI_DOES_NOT_EXIST,
       HintCode.PACKAGE_IMPORT_CONTAINS_DOT_DOT
     ]);
   }
 
   void test_import_referenceIntoLibDirectory() {
     cacheSource("/myproj/pubspec.yaml", "");
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
-    addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
+        addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
     computeLibrarySourceErrors(source);
     assertErrors(
         source, [HintCode.FILE_IMPORT_OUTSIDE_LIB_REFERENCES_FILE_INSIDE]);
   }
 
   void test_import_referenceIntoLibDirectory_no_pubspec() {
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
-    addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
+        addNamedSource("/myproj/web/test.dart", "import '../lib/other.dart';");
     computeLibrarySourceErrors(source);
     assertNoErrors(source);
   }
 
   void test_import_referenceOutOfLibDirectory() {
     cacheSource("/myproj/pubspec.yaml", "");
     cacheSource("/myproj/web/other.dart", "");
     Source source =
-    addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
+        addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
     computeLibrarySourceErrors(source);
     assertErrors(
         source, [HintCode.FILE_IMPORT_INSIDE_LIB_REFERENCES_FILE_OUTSIDE]);
   }
 
   void test_import_referenceOutOfLibDirectory_no_pubspec() {
     cacheSource("/myproj/web/other.dart", "");
     Source source =
-    addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
+        addNamedSource("/myproj/lib/test.dart", "import '../web/other.dart';");
     computeLibrarySourceErrors(source);
     assertNoErrors(source);
   }
 
   void test_import_valid_inside_lib1() {
     cacheSource("/myproj/pubspec.yaml", "");
     cacheSource("/myproj/lib/other.dart", "");
     Source source =
-    addNamedSource("/myproj/lib/test.dart", "import 'other.dart';");
+        addNamedSource("/myproj/lib/test.dart", "import 'other.dart';");
     computeLibrarySourceErrors(source);
     assertNoErrors(source);
   }
 
   void test_import_valid_inside_lib2() {
     cacheSource("/myproj/pubspec.yaml", "");
     cacheSource("/myproj/lib/bar/other.dart", "");
     Source source = addNamedSource(
         "/myproj/lib/foo/test.dart", "import '../bar/other.dart';");
     computeLibrarySourceErrors(source);
     assertNoErrors(source);
   }
 
   void test_import_valid_outside_lib() {
     cacheSource("/myproj/pubspec.yaml", "");
     cacheSource("/myproj/web/other.dart", "");
     Source source =
-    addNamedSource("/myproj/lib2/test.dart", "import '../web/other.dart';");
+        addNamedSource("/myproj/lib2/test.dart", "import '../web/other.dart';");
     computeLibrarySourceErrors(source);
     assertNoErrors(source);
   }
 }