Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1797413002: Update WindowTreeClientTest.OnEmbeddedAppDisconnected (Closed)

Created:
4 years, 9 months ago by jonross
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WindowTreeClientTest.OnEmbeddedAppDisconnected The exptectations of WindowTreeClientTest.OnEmbeddedAppDisconnected are no longer correct. With embed root removed, non owning connections should not be notified of disconnections. This change updates the test to reflect the expected behaviour TEST=WindowTreeClientTest.OnEmbeddedAppDisconnected BUG=594181 Committed: https://crrev.com/68ff87daa6693938ff4750a612137cdaf089f705 Cr-Commit-Position: refs/heads/master@{#381318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M components/mus/ws/window_tree_client_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hi, This brings the last WindowTreeClientTest back online. PTAL
4 years, 9 months ago (2016-03-15 19:22:41 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-15 20:40:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797413002/1
4 years, 9 months ago (2016-03-15 20:53:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 21:29:18 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 21:30:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68ff87daa6693938ff4750a612137cdaf089f705
Cr-Commit-Position: refs/heads/master@{#381318}

Powered by Google App Engine
This is Rietveld 408576698