Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: components/mus/ws/window_tree_client_unittest.cc

Issue 1797413002: Update WindowTreeClientTest.OnEmbeddedAppDisconnected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/ws/window_tree_client_unittest.cc
diff --git a/components/mus/ws/window_tree_client_unittest.cc b/components/mus/ws/window_tree_client_unittest.cc
index c00f5e379d18b167539c0e0e3ca7ec4c7d398cd4..aadb161374ec2a7d2babd107504d5f7fe32c7436 100644
--- a/components/mus/ws/window_tree_client_unittest.cc
+++ b/components/mus/ws/window_tree_client_unittest.cc
@@ -1620,7 +1620,7 @@ TEST_F(WindowTreeClientTest, SetWindowProperty) {
}
}
-TEST_F(WindowTreeClientTest, DISABLED_OnEmbeddedAppDisconnected) {
+TEST_F(WindowTreeClientTest, OnEmbeddedAppDisconnected) {
// Create connection 2 and 3.
ASSERT_NO_FATAL_FAILURE(EstablishSecondConnection(true));
Id window_1_1 = BuildWindowId(connection_id_1(), 1);
@@ -1641,9 +1641,10 @@ TEST_F(WindowTreeClientTest, DISABLED_OnEmbeddedAppDisconnected) {
EXPECT_EQ("OnEmbeddedAppDisconnected window=" + IdToString(window_2_1),
SingleChangeToDescription(*changes2()));
- wt_client1_->WaitForChangeCount(1);
- EXPECT_EQ("OnEmbeddedAppDisconnected window=" + IdToString(window_2_1),
- SingleChangeToDescription(*changes1()));
+ // The closing is only interesting to the root that did the embedding. Other
+ // connections should not be notified of this.
+ wt_client1_->WaitForAllMessages();
+ EXPECT_TRUE(changes1()->empty());
}
// Verifies when the parent of an Embed() is destroyed the embedded app gets
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698