Make ImageBitmap transferable work with ImageBitmapOptions

Make ImageBitmap transferable work with ImageBitmapOptions

At this moment, transfer an ImageBitmap works fine with an ImageBitmap
created with the default options. Now that we have options of flipY and
premultiplyAlpha, we should make sure that the transfer logic works.

To verify that, we create an ImageBitmap with flipY=true and premultiplyAlpha
=false, we transfer this ImageBitmap to the worker thread and worker
transfer it back to the main thread. Now on the main thread, the ImageBitmap
should have the same pixel data as the originally created one.

The tricky part here is that when transferring an ImageBitmap to worker,
we are actually pass a StaticBitmapImage which is stored internally in
the ImageBitmap. Since StaticBitmapImage doesn't have info about whether
it is premultiplied alpha or not, we will lose this info. To make sure
the transferring logic is correct, we add a member m_isPremultiplied to
StaticBitmapImage, and ImageBitmap keeps track of this member.

A layout test is added to make sure that the ImageBitmap's pixel data
survives the round trip from main<-->worker thread.

Committed: https://crrev.com/162000219b284ce3b5e98129d8bde4f06bb9c8cc
Cr-Commit-Position: refs/heads/master@{#383780}

[xidachen, 2016-03-15 15:53:04]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-03-15 15:53:04]

PTAL

[xidachen, 2016-03-24 14:22:20]

PTAL

[xidachen, 2016-03-29 13:57:18]

junov@: gentle ping.

[Justin Novosad, 2016-03-29 14:39:54]

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-transferable.html
(right):

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-transferable.html:58:
createImageBitmap(image, {imageOrientation: "flipY", premultiplyAlpha:
"none"}).then(function(imageBitmap) {
The way this test works is non-trivial, you should explain it in a comment.

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h (right):

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h:35: bool
m_isPremultiplied = true;
Please add a note stating that the need to store this information here stems
from the fact that SkImage public API does not expose its image info.

[xidachen, 2016-03-29 15:41:01]

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-transferable.html
(right):

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-transferable.html:58:
createImageBitmap(image, {imageOrientation: "flipY", premultiplyAlpha:
"none"}).then(function(imageBitmap) {
On 2016/03/29 14:39:53, Justin Novosad wrote:
> The way this test works is non-trivial, you should explain it in a comment.

Done.

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h (right):

https://codereview.chromium.org/1797313002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h:35: bool
m_isPremultiplied = true;
On 2016/03/29 14:39:53, Justin Novosad wrote:
> Please add a note stating that the need to store this information here stems
> from the fact that SkImage public API does not expose its image info.

Done.

[Justin Novosad, 2016-03-29 15:47:01]

lgtm

[xidachen, 2016-03-29 15:51:09]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 15:51:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1797313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1797313002/80001

[xidachen, 2016-03-29 17:13:11]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-03-29 17:13:32]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:13:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1797313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1797313002/80001

[commit-bot: I haz the power, 2016-03-29 18:48:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-29 18:49:08]

Description was changed from

==========
Make ImageBitmap transferable work with ImageBitmapOptions

At this moment, transfer an ImageBitmap works fine with an ImageBitmap
created with the default options. Now that we have options of flipY and
premultiplyAlpha, we should make sure that the transfer logic works.

To verify that, we create an ImageBitmap with flipY=true and premultiplyAlpha
=false, we transfer this ImageBitmap to the worker thread and worker
transfer it back to the main thread. Now on the main thread, the ImageBitmap
should have the same pixel data as the originally created one.

The tricky part here is that when transferring an ImageBitmap to worker,
we are actually pass a StaticBitmapImage which is stored internally in
the ImageBitmap. Since StaticBitmapImage doesn't have info about whether
it is premultiplied alpha or not, we will lose this info. To make sure
the transferring logic is correct, we add a member m_isPremultiplied to
StaticBitmapImage, and ImageBitmap keeps track of this member.

A layout test is added to make sure that the ImageBitmap's pixel data
survives the round trip from main<-->worker thread.
==========

to

==========
Make ImageBitmap transferable work with ImageBitmapOptions

At this moment, transfer an ImageBitmap works fine with an ImageBitmap
created with the default options. Now that we have options of flipY and
premultiplyAlpha, we should make sure that the transfer logic works.

To verify that, we create an ImageBitmap with flipY=true and premultiplyAlpha
=false, we transfer this ImageBitmap to the worker thread and worker
transfer it back to the main thread. Now on the main thread, the ImageBitmap
should have the same pixel data as the originally created one.

The tricky part here is that when transferring an ImageBitmap to worker,
we are actually pass a StaticBitmapImage which is stored internally in
the ImageBitmap. Since StaticBitmapImage doesn't have info about whether
it is premultiplied alpha or not, we will lose this info. To make sure
the transferring logic is correct, we add a member m_isPremultiplied to
StaticBitmapImage, and ImageBitmap keeps track of this member.

A layout test is added to make sure that the ImageBitmap's pixel data
survives the round trip from main<-->worker thread.

Committed: https://crrev.com/162000219b284ce3b5e98129d8bde4f06bb9c8cc
Cr-Commit-Position: refs/heads/master@{#383780}
==========

[commit-bot: I haz the power, 2016-03-29 18:49:09]

Patchset 5 (id:??) landed as
https://crrev.com/162000219b284ce3b5e98129d8bde4f06bb9c8cc
Cr-Commit-Position: refs/heads/master@{#383780}