Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: media/blink/webmediaplayer_delegate.h

Issue 1796403002: Don't mark a WebMediaPlayer as idle until it has size and first frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_delegate.h
diff --git a/media/blink/webmediaplayer_delegate.h b/media/blink/webmediaplayer_delegate.h
index 30dfc91f5dc3687adead5ee8ed7c1ebc92abdbd9..c70b07f38c6aed1020ee668917f32d06a081f62c 100644
--- a/media/blink/webmediaplayer_delegate.h
+++ b/media/blink/webmediaplayer_delegate.h
@@ -53,7 +53,10 @@ class WebMediaPlayerDelegate {
bool is_remote,
base::TimeDelta duration) = 0;
- // The specified player stopped playing media.
+ // The specified player stopped playing media. This may be called at any time
+ // with or without a DidPlay() having previously occurred. Calling this will
+ // cause the delegate to be registered for idle suspension. I.e., after some
+ // time elapses without a DidPlay(), OnSuspendRequested() will be issued.
virtual void DidPause(int delegate_id, bool reached_end_of_stream) = 0;
// The specified player was destroyed or suspended and will no longer accept

Powered by Google App Engine
This is Rietveld 408576698