content/browser/service_worker/service_worker_registration.cc - Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch for landing? Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_fetch_dispatcher.cc ('K') | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_url_request_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index e1e6e5d1822761c4b0914478fdc93e89b7911232..d24c8c936108163f0ed77e733eb39c4ed92ff785 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -287,6 +287,7 @@ void ServiceWorkerRegistration::ActivateWaitingVersion() {

// "10. Queue a task to fire an event named activate..."

activating_version->RunAfterStartWorker(

+ ServiceWorkerMetrics::EventType::ACTIVATE,

base::Bind(&ServiceWorkerRegistration::DispatchActivateEvent, this,

activating_version),

base::Bind(&ServiceWorkerRegistration::OnActivateEventFinished, this,