content/browser/service_worker/service_worker_register_job.cc - Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 1795863006: service worker: Attribute purpose to start worker attempts for UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch for landing? Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_fetch_dispatcher.cc ('K') | « content/browser/service_worker/service_worker_metrics.cc ('k') | content/browser/service_worker/service_worker_registration.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index ae7b436b00946fad25eec26ecf8bc2ed60f85b12..6f0155ab7e4936def883826fc3e8c918a4456278 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -351,6 +351,7 @@ void ServiceWorkerRegisterJob::UpdateAndContinue() {

new_version()->set_pause_after_download(false);

}

new_version()->StartWorker(

+ ServiceWorkerMetrics::EventType::INSTALL,

base::Bind(&ServiceWorkerRegisterJob::OnStartWorkerFinished,

weak_factory_.GetWeakPtr()));

}

@@ -414,6 +415,7 @@ void ServiceWorkerRegisterJob::InstallAndContinue() {

// "Fire an event named install..."

new_version()->RunAfterStartWorker(

+ ServiceWorkerMetrics::EventType::INSTALL,

base::Bind(&ServiceWorkerRegisterJob::DispatchInstallEvent,

weak_factory_.GetWeakPtr()),

base::Bind(&ServiceWorkerRegisterJob::OnInstallFinished,