Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 179493002: Add null check to fill, stroke, clip method (Closed)

Created:
6 years, 10 months ago by zino
Modified:
6 years, 9 months ago
Reviewers:
Rik, Justin Novosad, eseidel
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added null check and exception handling to fill, stroke, clip method. Added null and invalid argument test cases. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168280

Patch Set 1 #

Patch Set 2 : add exception handling and layout tests #

Patch Set 3 : expected.txt #

Patch Set 4 : expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -21 lines) Patch
M LayoutTests/fast/canvas/canvas-path-context-clip-expected.txt View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-path-context-fill-expected.txt View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-path-context-stroke-expected.txt View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-clip.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-fill.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-context-stroke.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-clip-expected.txt View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-fill-expected.txt View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-stroke-expected.txt View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 chunks +28 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
zino
6 years, 10 months ago (2014-02-25 09:03:42 UTC) #1
Justin Novosad
On 2014/02/25 09:03:42, zino wrote: Please add a layout test that calls these methods with ...
6 years, 10 months ago (2014-02-25 15:36:07 UTC) #2
zino
On 2014/02/25 15:36:07, junov wrote: > On 2014/02/25 09:03:42, zino wrote: > > Please add ...
6 years, 9 months ago (2014-02-28 06:38:31 UTC) #3
Justin Novosad
On 2014/02/28 06:38:31, zino wrote: > On 2014/02/25 15:36:07, junov wrote: > > On 2014/02/25 ...
6 years, 9 months ago (2014-02-28 15:05:46 UTC) #4
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-02 04:52:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/179493002/20001
6 years, 9 months ago (2014-03-02 04:52:39 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-02 06:23:52 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=23715
6 years, 9 months ago (2014-03-02 06:23:54 UTC) #8
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-03 05:01:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/179493002/40001
6 years, 9 months ago (2014-03-03 05:01:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 06:42:34 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=23743
6 years, 9 months ago (2014-03-03 06:42:35 UTC) #12
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-03 07:09:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/179493002/60001
6 years, 9 months ago (2014-03-03 07:10:05 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 09:02:35 UTC) #15
Message was sent while issue was closed.
Change committed as 168280

Powered by Google App Engine
This is Rietveld 408576698