Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.idl

Issue 179493002: Add null check to fill, stroke, clip method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: expected.txt Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/canvas/CanvasRenderingContext2D.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/canvas/CanvasRenderingContext2D.idl
diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.idl b/Source/core/html/canvas/CanvasRenderingContext2D.idl
index 970d4ff7b3eb84ac22245cd42cbb89e0001d522e..8c8eb6eca983c6696f5d45193697ee64d148cd64 100644
--- a/Source/core/html/canvas/CanvasRenderingContext2D.idl
+++ b/Source/core/html/canvas/CanvasRenderingContext2D.idl
@@ -78,16 +78,16 @@ interface CanvasRenderingContext2D : CanvasRenderingContext {
// FIXME: Simplify these using optional CanvasWindingRule once crbug.com/339000 gets fixed.
void fill();
- [RuntimeEnabled=ExperimentalCanvasFeatures] void fill(Path path);
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void fill(Path? path);
void fill(CanvasWindingRule winding);
- [RuntimeEnabled=ExperimentalCanvasFeatures] void fill(Path path, CanvasWindingRule winding);
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void fill(Path? path, CanvasWindingRule winding);
void stroke();
- [RuntimeEnabled=ExperimentalCanvasFeatures] void stroke(Path path);
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void stroke(Path? path);
// FIXME: Simplify these using optional CanvasWindingRule once crbug.com/339000 gets fixed.
void clip();
- [RuntimeEnabled=ExperimentalCanvasFeatures] void clip(Path path);
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void clip(Path? path);
void clip(CanvasWindingRule winding);
- [RuntimeEnabled=ExperimentalCanvasFeatures] void clip(Path path, CanvasWindingRule winding);
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void clip(Path? path, CanvasWindingRule winding);
boolean isPointInPath(float x, float y, optional CanvasWindingRule winding);
boolean isPointInStroke(float x, float y);
« no previous file with comments | « Source/core/html/canvas/CanvasRenderingContext2D.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698