Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(55)

Issue 1794553002: [Playground] Onion Soup: moving ScreenWakeLock to Blink modules/ (Closed)

Created:
4 years ago by mcasas
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+watch, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Playground] Onion Soup: moving ScreenWakeLock to Blink modules/ This CL: - moves wake_lock_service.mojom to WebKit/public/platform/modules/wake_lock/ and adapts include paths, gyps, gns and DEPS (which is a large amount of this CL) - removes the files content/renderer/wake_lock/wake_lock_dispatcher.* WebKit/Source/platform/wake_lock/WebWakeLockClient.h since their functionality is folded into WebKit/public/platform/modules/wake_lock/ScreenWakeLock.* which is modified to talks directly to the mojo service impl in browser's render frame host. - moves ScreenWakeLockTest.cpp is moved to modules/ - and refactors said test to use a mojo MockWakeLockService. BUG=600895 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 : some cleanup in the gyp/gn/DEPS range #

Patch Set 2 : nit DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -390 lines) Patch
M content/browser/DEPS View 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/wake_lock/wake_lock_service_impl.h View 2 chunks +8 lines, -7 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/wake_lock_service.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -8 lines 0 comments Download
D content/renderer/wake_lock/wake_lock_dispatcher.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/renderer/wake_lock/wake_lock_dispatcher.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/wake_lock/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h View 2 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp View 6 chunks +37 lines, -28 lines 0 comments Download
A + third_party/WebKit/Source/modules/wake_lock/ScreenWakeLockTest.cpp View 5 chunks +55 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/public/platform/modules/wake_lock/WebWakeLockClient.h View 1 chunk +0 lines, -19 lines 0 comments Download
A + third_party/WebKit/public/platform/modules/wake_lock/wake_lock_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 43 (43 generated)
mcasas
Patchset #1 (id:1) has been deleted
4 years ago (2016-03-12 02:03:57 UTC) #1
mcasas
Patchset #1 (id:20001) has been deleted
4 years ago (2016-03-12 02:04:03 UTC) #2
mcasas
Description was changed from ========== Experimental: Onion Soup: moving ScreenWakeLock to Blink BUG= ========== to ...
4 years ago (2016-03-12 02:08:52 UTC) #3
mcasas
Patchset #2 (id:60001) has been deleted
4 years ago (2016-03-12 02:09:25 UTC) #4
mcasas
Patchset #1 (id:40001) has been deleted
4 years ago (2016-03-12 02:09:32 UTC) #5
mcasas
Patchset #2 (id:100001) has been deleted
4 years ago (2016-03-15 01:22:24 UTC) #6
mcasas
Patchset #2 (id:120001) has been deleted
4 years ago (2016-03-15 01:22:35 UTC) #7
mcasas
Patchset #1 (id:80001) has been deleted
4 years ago (2016-03-15 23:10:53 UTC) #8
mcasas
Patchset #1 (id:140001) has been deleted
4 years ago (2016-03-15 23:11:17 UTC) #9
mcasas
Patchset #1 (id:160001) has been deleted
4 years ago (2016-03-15 23:17:04 UTC) #10
mcasas
Patchset #2 (id:200001) has been deleted
4 years ago (2016-03-16 02:28:01 UTC) #11
mcasas
Patchset #1 (id:180001) has been deleted
4 years ago (2016-03-16 21:45:56 UTC) #12
mcasas
Patchset #1 (id:220001) has been deleted
4 years ago (2016-03-16 21:57:28 UTC) #13
mcasas
Patchset #2 (id:260001) has been deleted
4 years ago (2016-03-16 22:26:39 UTC) #14
mcasas
Patchset #1 (id:240001) has been deleted
4 years ago (2016-03-16 22:26:51 UTC) #15
mcasas
Patchset #1 (id:280001) has been deleted
4 years ago (2016-03-17 18:46:45 UTC) #16
mcasas
Patchset #1 (id:300001) has been deleted
4 years ago (2016-03-17 20:00:48 UTC) #17
mcasas
Patchset #1 (id:320001) has been deleted
4 years ago (2016-03-17 20:01:29 UTC) #18
mcasas
Patchset #1 (id:340001) has been deleted
4 years ago (2016-03-17 20:01:51 UTC) #19
mcasas
Description was changed from ========== Experimental: Onion Soup: moving ScreenWakeLock to Blink content/renderer/wake_lock/wake_lock_dispatcher.* ==> WebKit/Source/platform/wake_lock/WakeLockDispatcher.* ...
4 years ago (2016-03-17 23:12:11 UTC) #20
mcasas
Description was changed from ========== Experimental: Onion Soup: moving ScreenWakeLock to Blink content/renderer/wake_lock/wake_lock_dispatcher.* ==> WebKit/Source/platform/wake_lock/WakeLockDispatcher.* ...
4 years ago (2016-04-05 00:37:16 UTC) #21
mcasas
Patchset #1 (id:360001) has been deleted
4 years ago (2016-04-05 00:43:27 UTC) #22
mcasas
Patchset #2 (id:400001) has been deleted
4 years ago (2016-04-05 01:27:16 UTC) #23
mcasas
Patchset #3 (id:440001) has been deleted
4 years ago (2016-04-05 04:16:23 UTC) #24
mcasas
Patchset #3 (id:460001) has been deleted
4 years ago (2016-04-05 04:16:31 UTC) #25
mcasas
Description was changed from ========== Experimental: Onion Soup: moving ScreenWakeLock to Blink Moving wake_lock_Service.mojom to ...
4 years ago (2016-04-06 01:28:39 UTC) #26
mcasas
Patchset #2 (id:420001) has been deleted
4 years ago (2016-04-06 01:30:09 UTC) #27
mcasas
Patchset #2 (id:480001) has been deleted
4 years ago (2016-04-06 01:30:18 UTC) #28
mcasas
Description was changed from ========== Experimental: Onion Soup: moving ScreenWakeLock to Blink Moving wake_lock_Service.mojom to ...
4 years ago (2016-04-08 00:31:51 UTC) #29
mcasas
Patchset #8 (id:610001) has been deleted
4 years ago (2016-04-08 18:55:47 UTC) #30
mcasas
Description was changed from ========== Experimental: Onion Soup: moving ScreenWakeLock to Blink Moving wake_lock_Service.mojom to ...
4 years ago (2016-04-08 18:58:18 UTC) #31
mcasas
Patchset #1 (id:380001) has been deleted
4 years ago (2016-04-09 00:42:29 UTC) #32
mcasas
Patchset #1 (id:500001) has been deleted
4 years ago (2016-04-09 00:42:40 UTC) #33
mcasas
Patchset #1 (id:520001) has been deleted
4 years ago (2016-04-09 00:42:50 UTC) #34
mcasas
Patchset #1 (id:540001) has been deleted
4 years ago (2016-04-09 00:43:01 UTC) #35
mcasas
Patchset #1 (id:560001) has been deleted
4 years ago (2016-04-09 00:43:11 UTC) #36
mcasas
Patchset #1 (id:570001) has been deleted
4 years ago (2016-04-09 00:43:24 UTC) #37
mcasas
Patchset #1 (id:590001) has been deleted
4 years ago (2016-04-09 00:43:36 UTC) #38
mcasas
Patchset #1 (id:630001) has been deleted
4 years ago (2016-04-09 00:43:44 UTC) #39
mcasas
Patchset #1 (id:650001) has been deleted
4 years ago (2016-04-09 00:43:52 UTC) #40
mcasas
Description was changed from ========== Onion Soup: moving ScreenWakeLock to Blink modules/ Moving wake_lock_service.mojom to ...
4 years ago (2016-04-09 00:45:37 UTC) #41
mcasas
Description was changed from ========== Onion Soup: moving ScreenWakeLock to Blink modules/ This CL: - ...
4 years ago (2016-04-09 01:25:46 UTC) #42
mcasas
3 years, 12 months ago (2016-04-11 18:18:31 UTC) #43
Description was changed from

==========
Onion Soup: moving ScreenWakeLock to Blink modules/

This CL:
- moves wake_lock_service.mojom to
 WebKit/public/platform/modules/wake_lock/
 and adapts include paths, gyps, gns and DEPS
 (which is a large amount of this CL)

- removes the files 
  content/renderer/wake_lock/wake_lock_dispatcher.*
  WebKit/Source/platform/wake_lock/WebWakeLockClient.h

 since their functionality is folded into 
  WebKit/public/platform/modules/wake_lock/ScreenWakeLock.*
 which is modified to talks directly to the mojo 
 service impl in browser's render frame host.

- moves ScreenWakeLockTest.cpp is moved to modules/ 

- and refactors said test to use a mojo MockWakeLockService.


BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[Playground] Onion Soup: moving ScreenWakeLock to Blink modules/

This CL:
- moves wake_lock_service.mojom to
 WebKit/public/platform/modules/wake_lock/
 and adapts include paths, gyps, gns and DEPS
 (which is a large amount of this CL)

- removes the files 
  content/renderer/wake_lock/wake_lock_dispatcher.*
  WebKit/Source/platform/wake_lock/WebWakeLockClient.h

 since their functionality is folded into 
  WebKit/public/platform/modules/wake_lock/ScreenWakeLock.*
 which is modified to talks directly to the mojo 
 service impl in browser's render frame host.

- moves ScreenWakeLockTest.cpp is moved to modules/ 

- and refactors said test to use a mojo MockWakeLockService.


BUG=600895
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698