Revert "Add --no-commit option to apply_issue for use with git on the bots."

Revert "Add --no-commit option to apply_issue for use with git on the bots."

This reverts commit 012dc07ce5a194e74503d64a9b1719abc0b3aa3b.

Revert "Partially revert r208574 to get the CQ working again (hopefully)."

This reverts commit 74105cd2a02d09032bb15b21fe516ea021715729.

Pull the --no-commit change out completely.

TBR=dpranke@chromium.org
BUG=254556
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208801

[commit-bot: I haz the power, 2013-06-26 22:04:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/17944002/1

[iannucci, 2013-06-26 22:04:39]

On 2013/06/26 21:23:58, iannucci wrote:

(reverted the consumer of this flag already)

[Dirk Pranke, 2013-06-26 22:04:50]

lgtm. feel free to land assuming you've removed the flag from the recipe as
discussed.

[iannucci, 2013-06-26 22:05:46]

On 2013/06/26 22:04:50, Dirk Pranke wrote:
> lgtm. feel free to land assuming you've removed the flag from the recipe as
> discussed.

mid-air collision on emails :). I did revert the recipe portion already.

[commit-bot: I haz the power, 2013-06-26 22:06:03]

Presubmit check for 17944002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1381 --:--:-- --:--:-- --:--:--  1400
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5629499534213120'
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1612 --:--:-- --:--:-- --:--:--  1638
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5840605766746112'
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


Presubmit checks took 95.0s to calculate.

[iannucci, 2013-06-26 22:15:52]

Committed patchset #1 manually as r208801.