Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: apply_issue.py

Issue 17944002: Revert "Add --no-commit option to apply_issue for use with git on the bots." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apply_issue.py
diff --git a/apply_issue.py b/apply_issue.py
index b333bd816f3cb32f0bf51992a3e3c1d04a66d412..30748fd7564314c2357525e63e6c9fd0034a3107 100755
--- a/apply_issue.py
+++ b/apply_issue.py
@@ -65,8 +65,6 @@ def main():
'--server',
default='http://codereview.chromium.org',
help='Rietveld server')
- parser.add_option('--no-commit', action='store_true',
- help='Do not try to commit patch to SCM (git only)')
options, args = parser.parse_args()
logging.basicConfig(
format='%(levelname)5s %(module)11s(%(lineno)4d): %(message)s',
@@ -139,13 +137,11 @@ def main():
print(patch)
full_dir = os.path.abspath(options.root_dir)
scm_type = scm.determine_scm(full_dir)
-
- # FIXME: re-enable --no-commit.
if scm_type == 'svn':
scm_obj = checkout.SvnCheckout(full_dir, None, None, None, None)
elif scm_type == 'git':
scm_obj = checkout.GitCheckoutBase(full_dir, None, None)
- elif scm_type is None:
+ elif scm_type == None:
scm_obj = checkout.RawCheckout(full_dir, None, None)
else:
parser.error('Couldn\'t determine the scm')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698