Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1794393002: Devtools: Fix space key in Styles pane editing (Closed)

Created:
4 years, 9 months ago by samli
Modified:
4 years, 9 months ago
Reviewers:
tkent, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Fix space key in Styles pane editing This bug was exposed in https://codereview.chromium.org/1780413002 BUG=594313 Committed: https://crrev.com/157188cbd7fc000a5920242c72a716f6c639b549 Cr-Commit-Position: refs/heads/master@{#380940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
samli
tkent: PTAL. lushnikov: FYI. There are some behavioral differences after adding whitespace, saving, editing again. ...
4 years, 9 months ago (2016-03-14 05:52:15 UTC) #2
tkent
lgtm
4 years, 9 months ago (2016-03-14 05:53:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1794393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1794393002/1
4 years, 9 months ago (2016-03-14 05:53:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 07:02:53 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 07:04:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/157188cbd7fc000a5920242c72a716f6c639b549
Cr-Commit-Position: refs/heads/master@{#380940}

Powered by Google App Engine
This is Rietveld 408576698