Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is plain-text editable a…

Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is plain-text editable and the incoming fragment is plain-text.

The purposes of this CL:
* Do not modify incoming text for plain-text editing.  We unexpectedly converted
  EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.

BUG=2007, 410417, 453802, 528491, 586772, 591697
Committed: https://crrev.com/e26eb3267527f0d5633283cef06a13995e0d41eb
Cr-Commit-Position: refs/heads/master@{#380527}

[tkent, 2016-03-11 01:00:58]

Description was changed from

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

BUG=
==========

to

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

BUG=2007,410417,453802,528491,591697
==========

[tkent, 2016-03-11 01:04:36]

Description was changed from

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

BUG=2007,410417,453802,528491,591697
==========

to

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

The purposes of this CL:
* Do not modify incoming text for plain-text editing.  We unexpectedly converted
  EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.

BUG=2007,410417,453802,528491,591697
==========

[tkent, 2016-03-11 01:11:21]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-03-11 01:11:22]

yosin@, would you review this please?

https://codereview.chromium.org/1780413002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html
(right):

https://codereview.chromium.org/1780413002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/input/paste-linebreak-into-initially-hidden-textarea.html:21:
var expected = 'hello\nworld\n\nwebkit';
The original expectation was wrong.  It expected \n\n was collapsed.

[yosin_UTC9, 2016-03-11 02:10:55]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-03-11 02:10:55]

lgtm

[commit-bot: I haz the power, 2016-03-11 02:11:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780413002/1

[tkent, 2016-03-11 02:12:13]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-03-11 02:13:56]

fast/forms/8250.html is failing with Patch Set 1.  I'm wondering if we should
fix code or should remove the test.

[tkent, 2016-03-11 02:17:26]

On 2016/03/11 at 02:13:56, tkent wrote:
> fast/forms/8250.html is failing with Patch Set 1.  I'm wondering if we should
fix code or should remove the test.

When we paste plain text, we can have only the trailing AppleInterchangeNewline.
 So, the fast path of ReplacementFragment should accept the trailing
AppletInterchangeNewline.  It will make the test passing.

[tkent, 2016-03-11 04:00:58]

Description was changed from

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

The purposes of this CL:
* Do not modify incoming text for plain-text editing.  We unexpectedly converted
  EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.

BUG=2007,410417,453802,528491,591697
==========

to

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

The purposes of this CL:
* Do not modify incoming text for plain-text editing.  We unexpectedly converted
  EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.

BUG=2007,410417,453802,528491,586772,591697
==========

[tkent, 2016-03-11 05:11:57]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-03-11 05:11:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1780413002/#ps20001
(title: "accept only last interchangenewline")

[commit-bot: I haz the power, 2016-03-11 05:13:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780413002/20001

[commit-bot: I haz the power, 2016-03-11 05:24:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 05:27:05]

Description was changed from

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

The purposes of this CL:
* Do not modify incoming text for plain-text editing.  We unexpectedly converted
  EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.

BUG=2007,410417,453802,528491,586772,591697
==========

to

==========
Editing: Skip TestRendering in ReplaceSelectionCommand if the editing host is
plain-text editable and the incoming fragment is plain-text.

The purposes of this CL:
* Do not modify incoming text for plain-text editing.  We unexpectedly converted
  EOL characters for TEXTAREA.
* Improve performance of text insertion in plain-text editing.

BUG=2007,410417,453802,528491,586772,591697

Committed: https://crrev.com/e26eb3267527f0d5633283cef06a13995e0d41eb
Cr-Commit-Position: refs/heads/master@{#380527}
==========

[commit-bot: I haz the power, 2016-03-11 05:27:06]

Patchset 2 (id:??) landed as
https://crrev.com/e26eb3267527f0d5633283cef06a13995e0d41eb
Cr-Commit-Position: refs/heads/master@{#380527}