third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 1793933002: Don't trigger a link resource fetch on media change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1793933002: Don't trigger a link resource fetch on media change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test and made mediaChanged() virtual Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLLinkElement.cpp ('K') | « third_party/WebKit/Source/core/html/LinkResource.h ('k') | third_party/WebKit/Source/web/tests/data/link-manifest-change.html » ('j') | third_party/WebKit/Source/web/tests/data/link-manifest-change.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 78c617d086f34e1a43539c3828f18019dc322e94..ba220a8389b0e3c7ad99be4d5bf6ac3165ce76d1 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -6816,7 +6816,7 @@ TEST_P(ParameterizedWebFrameTest, NotifyManifestChange)

FrameTestHelpers::WebViewHelper webViewHelper(this);

webViewHelper.initializeAndLoad(m_baseURL + "link-manifest-change.html", true, &webFrameClient);

- EXPECT_EQ(14, webFrameClient.manifestChangeCount());

+ EXPECT_EQ(13, webFrameClient.manifestChangeCount());

}

static PassRefPtrWillBeRawPtr<Resource> fetchManifest(Document* document, const KURL& url)