Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1793933002: Don't trigger a link resource fetch on media change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test and made mediaChanged() virtual Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 6798 matching lines...) Expand 10 before | Expand all | Expand 10 after
6809 }; 6809 };
6810 6810
6811 TEST_P(ParameterizedWebFrameTest, NotifyManifestChange) 6811 TEST_P(ParameterizedWebFrameTest, NotifyManifestChange)
6812 { 6812 {
6813 registerMockedHttpURLLoad("link-manifest-change.html"); 6813 registerMockedHttpURLLoad("link-manifest-change.html");
6814 6814
6815 ManifestChangeWebFrameClient webFrameClient; 6815 ManifestChangeWebFrameClient webFrameClient;
6816 FrameTestHelpers::WebViewHelper webViewHelper(this); 6816 FrameTestHelpers::WebViewHelper webViewHelper(this);
6817 webViewHelper.initializeAndLoad(m_baseURL + "link-manifest-change.html", tru e, &webFrameClient); 6817 webViewHelper.initializeAndLoad(m_baseURL + "link-manifest-change.html", tru e, &webFrameClient);
6818 6818
6819 EXPECT_EQ(14, webFrameClient.manifestChangeCount()); 6819 EXPECT_EQ(13, webFrameClient.manifestChangeCount());
6820 } 6820 }
6821 6821
6822 static PassRefPtrWillBeRawPtr<Resource> fetchManifest(Document* document, const KURL& url) 6822 static PassRefPtrWillBeRawPtr<Resource> fetchManifest(Document* document, const KURL& url)
6823 { 6823 {
6824 FetchRequest fetchRequest = FetchRequest(ResourceRequest(url), FetchInitiato rInfo()); 6824 FetchRequest fetchRequest = FetchRequest(ResourceRequest(url), FetchInitiato rInfo());
6825 fetchRequest.mutableResourceRequest().setRequestContext(WebURLRequest::Reque stContextManifest); 6825 fetchRequest.mutableResourceRequest().setRequestContext(WebURLRequest::Reque stContextManifest);
6826 6826
6827 return RawResource::fetchSynchronously(fetchRequest, document->fetcher()); 6827 return RawResource::fetchSynchronously(fetchRequest, document->fetcher());
6828 } 6828 }
6829 6829
(...skipping 1683 matching lines...) Expand 10 before | Expand all | Expand 10 after
8513 } 8513 }
8514 8514
8515 TEST_F(WebFrameVisibilityChangeTest, RemoteFrameParentVisibilityChange) 8515 TEST_F(WebFrameVisibilityChangeTest, RemoteFrameParentVisibilityChange)
8516 { 8516 {
8517 swapLocalFrameToRemoteFrame(); 8517 swapLocalFrameToRemoteFrame();
8518 executeScriptOnMainFrame(WebScriptSource("document.querySelector('iframe').p arentElement.style.display = 'none';")); 8518 executeScriptOnMainFrame(WebScriptSource("document.querySelector('iframe').p arentElement.style.display = 'none';"));
8519 EXPECT_FALSE(remoteFrameClient()->isVisible()); 8519 EXPECT_FALSE(remoteFrameClient()->isVisible());
8520 } 8520 }
8521 8521
8522 } // namespace blink 8522 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698