[webcrypto] Add the KeyAlgorithm interface.

Source/modules/crypto/RsaHashedKeyAlgorithm.h

Index: Source/modules/crypto/RsaHashedKeyAlgorithm.h
diff --git a/Source/core/css/CSSFontSelectorClient.h b/Source/modules/crypto/RsaHashedKeyAlgorithm.h
similarity index 78%
copy from Source/core/css/CSSFontSelectorClient.h
copy to Source/modules/crypto/RsaHashedKeyAlgorithm.h
index 28a6c87742256f5224d530dc9d9110cf48f0a86e..db1af7badbaaf79234501aaa739c677124e24788 100644
--- a/Source/core/css/CSSFontSelectorClient.h
+++ b/Source/modules/crypto/RsaHashedKeyAlgorithm.h
@@ -28,20 +28,27 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef CSSFontSelectorClient_h
-#define CSSFontSelectorClient_h
+#ifndef RsaHashedKeyAlgorithm_h
+#define RsaHashedKeyAlgorithm_h
 
-namespace WebCore {
+#include "modules/crypto/RsaKeyAlgorithm.h"
 
-class CSSFontSelector;
+namespace WebCore {
 
-class CSSFontSelectorClient {
+class RsaHashedKeyAlgorithm : public RsaKeyAlgorithm {
 public:
-    virtual ~CSSFontSelectorClient() { }
+    static PassRefPtrWillBeRawPtr<RsaHashedKeyAlgorithm> create(const blink::WebCryptoKeyAlgorithm&);
+
+    KeyAlgorithm* hash();
+
+    void trace(Visitor*);

[haraken, 2014/02/25 09:15:46]

Add 'virtual' and 'OVERRIDE'. The same comment for other places.

Probably you don't want to add virtual functions for some reason? Then you can
use traceAfterDispatch() pattern. See how the CSSValue hierarchy is implemented.

[Mads Ager (chromium), 2014/02/25 09:34:18]

Good catch Haraken! KeyAlgorithm.h does not have a vtable. Therefore, the
question here is if it should have or if you always know the exact type of the
KeyAlgorithm you have a pointer to? I was assuming that you do, but that is
incorrect (right below there is a pointer to a KeyAlgorithm). If trace is not
virtual it needs to be explicitly dispatched (which means that you need a type
marker in the superclass to know the actual subtype you have - see CSSValue.h
and CSSValue.cpp for an example). I agree with Haraken that we should add a
vtable to this one and make the dispatch virtual here.

[eroman, 2014/02/26 01:37:36]

Done.

+
+protected:
+    RsaHashedKeyAlgorithm(const blink::WebCryptoKeyAlgorithm&);

[haraken, 2014/02/25 09:15:46]

Add 'explicit'.

[eroman, 2014/02/26 01:37:36]

Done.

[eroman, 2014/02/26 01:37:36]

Done.

 
-    virtual void fontsNeedUpdate(CSSFontSelector*) = 0;
+    RefPtrWillBeMember<KeyAlgorithm> m_hash;

[haraken, 2014/02/25 09:15:46]

Can this be a private member?

[eroman, 2014/02/26 01:37:36]

Done.

 };
 
 } // namespace WebCore
 
-#endif // CSSFontSelectorClient_h
+#endif