[webcrypto] Add the KeyAlgorithm interface.

Source/modules/crypto/RsaHashedKeyAlgorithm.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef CSSFontSelectorClient_h
-#define CSSFontSelectorClient_h
+#ifndef RsaHashedKeyAlgorithm_h
+#define RsaHashedKeyAlgorithm_h
+
+#include "modules/crypto/RsaKeyAlgorithm.h"
 
 namespace WebCore {
 
-class CSSFontSelector;
+class RsaHashedKeyAlgorithm : public RsaKeyAlgorithm {
+public:
+    static PassRefPtrWillBeRawPtr<RsaHashedKeyAlgorithm> create(const blink::WebCryptoKeyAlgorithm&);
 
-class CSSFontSelectorClient {
-public:
-    virtual ~CSSFontSelectorClient() { }
+    KeyAlgorithm* hash();
 
-    virtual void fontsNeedUpdate(CSSFontSelector*) = 0;
+    void trace(Visitor*);

[haraken, 2014/02/25 09:15:46]

Add 'virtual' and 'OVERRIDE'. The same comment for other places.

Probably you don't want to add virtual functions for some reason? Then you can
use traceAfterDispatch() pattern. See how the CSSValue hierarchy is implemented.

[Mads Ager (chromium), 2014/02/25 09:34:18]

Good catch Haraken! KeyAlgorithm.h does not have a vtable. Therefore, the
question here is if it should have or if you always know the exact type of the
KeyAlgorithm you have a pointer to? I was assuming that you do, but that is
incorrect (right below there is a pointer to a KeyAlgorithm). If trace is not
virtual it needs to be explicitly dispatched (which means that you need a type
marker in the superclass to know the actual subtype you have - see CSSValue.h
and CSSValue.cpp for an example). I agree with Haraken that we should add a
vtable to this one and make the dispatch virtual here.

[eroman, 2014/02/26 01:37:36]

Done.

+
+protected:
+    RsaHashedKeyAlgorithm(const blink::WebCryptoKeyAlgorithm&);

[haraken, 2014/02/25 09:15:46]

Add 'explicit'.

[eroman, 2014/02/26 01:37:36]

Done.

[eroman, 2014/02/26 01:37:36]

Done.

+
+    RefPtrWillBeMember<KeyAlgorithm> m_hash;

[haraken, 2014/02/25 09:15:46]

Can this be a private member?

[eroman, 2014/02/26 01:37:36]

Done.

 };
 
 } // namespace WebCore
 
-#endif // CSSFontSelectorClient_h
+#endif