[webcrypto] Add the KeyAlgorithm interface.

Source/modules/crypto/AesKeyAlgorithm.h

Index: Source/modules/crypto/AesKeyAlgorithm.h
diff --git a/Source/modules/crypto/WorkerCrypto.h b/Source/modules/crypto/AesKeyAlgorithm.h
similarity index 79%
copy from Source/modules/crypto/WorkerCrypto.h
copy to Source/modules/crypto/AesKeyAlgorithm.h
index b202763fb6ee62f47162fa0701cebd0eb4b50ec7..17222bf873b6c558ff2e44540403ad5bb846831f 100644
--- a/Source/modules/crypto/WorkerCrypto.h
+++ b/Source/modules/crypto/AesKeyAlgorithm.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
@@ -28,31 +28,30 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WorkerCrypto_h
-#define WorkerCrypto_h
+#ifndef AesKeyAlgorithm_h
+#define AesKeyAlgorithm_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "heap/Handle.h"
+#include "modules/crypto/KeyAlgorithm.h"
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
-class WorkerCrypto : public RefCountedWillBeGarbageCollectedFinalized<WorkerCrypto>, public ScriptWrappable {
-    DECLARE_GC_INFO;
+class AesKeyAlgorithm : public KeyAlgorithm {
 public:
-    static PassRefPtrWillBeRawPtr<WorkerCrypto> create()
-    {
-        return adoptRefWillBeNoop(new WorkerCrypto());
-    }
+    static PassRefPtrWillBeRawPtr<AesKeyAlgorithm> create(const blink::WebCryptoKeyAlgorithm&);
 
-    void trace(Visitor*) { }
+    unsigned short length();
 
-private:
-    WorkerCrypto();
+    void trace(Visitor*);

[abarth-chromium, 2014/02/25 07:51:41]

I don't think this is needed given that we're not adding any members.

[eroman, 2014/02/25 08:33:15]

Inlined it instead (I believe it needs to be defined even when empty)

[Mads Ager (chromium), 2014/02/25 08:49:25]

It doesn't actually have to be there. If it is not, the one in KeyAlgorithm will
be called. I like having it though. When we have a hierarchy with virtual
methods and therefore a virtual trace method, we define the trace methods for
the entire hierarchy in order to avoid bugs where we end up visiting only half
of the inheritance hierarchy. I think it makes it simpler if the rule of thumb
is to always define trace methods for the entire hierarchy.

+
+protected:
+    explicit AesKeyAlgorithm(const blink::WebCryptoKeyAlgorithm&);
 };
 
-}
+} // namespace WebCore
 
 #endif