[webcrypto] Add the KeyAlgorithm interface.

Source/modules/crypto/AesKeyAlgorithm.h

 /*
- * Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WorkerCrypto_h
-#define WorkerCrypto_h
+#ifndef AesKeyAlgorithm_h
+#define AesKeyAlgorithm_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "heap/Handle.h"
+#include "modules/crypto/KeyAlgorithm.h"
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
-class WorkerCrypto : public RefCountedWillBeGarbageCollectedFinalized<WorkerCrypto>, public ScriptWrappable {
-    DECLARE_GC_INFO;
+class AesKeyAlgorithm : public KeyAlgorithm {
 public:
-    static PassRefPtrWillBeRawPtr<WorkerCrypto> create()
-    {
-        return adoptRefWillBeNoop(new WorkerCrypto());
-    }
+    static PassRefPtrWillBeRawPtr<AesKeyAlgorithm> create(const blink::WebCryptoKeyAlgorithm&);
 
-    void trace(Visitor*) { }
+    unsigned short length();
 
-private:
-    WorkerCrypto();
+    void trace(Visitor*);

[abarth-chromium, 2014/02/25 07:51:41]

I don't think this is needed given that we're not adding any members.

[eroman, 2014/02/25 08:33:15]

Inlined it instead (I believe it needs to be defined even when empty)

[Mads Ager (chromium), 2014/02/25 08:49:25]

It doesn't actually have to be there. If it is not, the one in KeyAlgorithm will
be called. I like having it though. When we have a hierarchy with virtual
methods and therefore a virtual trace method, we define the trace methods for
the entire hierarchy in order to avoid bugs where we end up visiting only half
of the inheritance hierarchy. I think it makes it simpler if the rule of thumb
is to always define trace methods for the entire hierarchy.

+
+protected:
+    explicit AesKeyAlgorithm(const blink::WebCryptoKeyAlgorithm&);
 };
 
-}
+} // namespace WebCore
 
 #endif