Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1793273004: Revert of Implement QUIC-based net::BidirectionalStream (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
Reviewers:
mef, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@basecl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement QUIC-based net::BidirectionalStream (patchset #12 id:320001 of https://codereview.chromium.org/1744693002/ ) Reason for revert: This caused compile error on Cronet bots. Original issue's description: > Implement QUIC-based net::BidirectionalStream > > This CL implements a QUIC-based BidirectionalStream > and adds unit tests. > > BUG=584338 > > Committed: https://crrev.com/0527bf95252b833b591be2f8e116cffd004ff189 > Cr-Commit-Position: refs/heads/master@{#380919} TBR=mef@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584338 Committed: https://crrev.com/b3afb3ccd55aee90f2b0dd27a22950bd6f66f2fb Cr-Commit-Position: refs/heads/master@{#380921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -1978 lines) Patch
M net/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M net/http/http_stream_factory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 5 chunks +34 lines, -13 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 8 chunks +11 lines, -24 lines 0 comments Download
M net/http/http_stream_factory_impl_request.h View 4 chunks +10 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 6 chunks +0 lines, -232 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D net/quic/bidirectional_stream_quic_impl.h View 1 chunk +0 lines, -119 lines 0 comments Download
D net/quic/bidirectional_stream_quic_impl.cc View 1 chunk +0 lines, -262 lines 0 comments Download
D net/quic/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +0 lines, -1138 lines 0 comments Download
M net/quic/quic_stream_factory.h View 4 chunks +4 lines, -12 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 8 chunks +13 lines, -28 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 78 chunks +103 lines, -103 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
xunjieli
Created Revert of Implement QUIC-based net::BidirectionalStream
4 years, 9 months ago (2016-03-14 03:14:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793273004/1
4 years, 9 months ago (2016-03-14 03:14:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 03:15:21 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 03:16:51 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3afb3ccd55aee90f2b0dd27a22950bd6f66f2fb
Cr-Commit-Position: refs/heads/master@{#380921}

Powered by Google App Engine
This is Rietveld 408576698