Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: net/http/http_stream_factory_impl_request.h

Issue 1793273004: Revert of Implement QUIC-based net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@basecl
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_request.h
diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h
index cad61afcce468ef79c2f4538d9d088c8180f1131..a92303c97b912462ca26b1b4b7d06e892fa8a814 100644
--- a/net/http/http_stream_factory_impl_request.h
+++ b/net/http/http_stream_factory_impl_request.h
@@ -27,6 +27,12 @@
class HttpStreamFactoryImpl::Request : public HttpStreamRequest {
public:
+ // Indicates which type of stream is requested.
+ enum StreamType {
+ BIDIRECTIONAL_STREAM_SPDY_JOB,
+ HTTP_STREAM,
+ };
+
Request(const GURL& url,
HttpStreamFactoryImpl* factory,
HttpStreamRequest::Delegate* delegate,
@@ -63,9 +69,8 @@
void RemoveRequestFromSpdySessionRequestMap();
// Called by an attached Job if it sets up a SpdySession.
- // |stream| is null when |stream_type| is HttpStreamRequest::HTTP_STREAM.
- // |bidirectional_stream_spdy_job| is null when |stream_type| is
- // HttpStreamRequest::BIDIRECTIONAL_STREAM.
+ // |stream| is null when |for_bidirectional| is true.
+ // |bidirectional_stream_spdy_job| is null when |for_bidirectional| is false.
void OnNewSpdySessionReady(
Job* job,
scoped_ptr<HttpStream> stream,
@@ -134,7 +139,7 @@
NextProto protocol_negotiated() const override;
bool using_spdy() const override;
const ConnectionAttempts& connection_attempts() const override;
- HttpStreamRequest::StreamType stream_type() const { return stream_type_; }
+ bool for_bidirectional() const { return for_bidirectional_; }
private:
// Used to bind |job| to the request and orphan all other jobs in |jobs_|.
@@ -168,7 +173,7 @@
bool using_spdy_;
ConnectionAttempts connection_attempts_;
- const HttpStreamRequest::StreamType stream_type_;
+ const bool for_bidirectional_;
DISALLOW_COPY_AND_ASSIGN(Request);
};
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698