third_party/WebKit/Source/core/editing/FrameSelection.h - Issue 1793093006: [Editing][Stability] Recanonicalize m_originalbase in FrameSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1793093006: [Editing][Stability] Recanonicalize m_originalbase in FrameSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit pick Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/mouse/drag_selection_update_crash.html ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/FrameSelection.h

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h

index 259d7dff308ac23502bd0a5ec9adc7741f0201a0..961d1703184daaa6ba78055153e960ab832b1443 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.h

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h

@@ -258,8 +258,8 @@ private:

template <typename Strategy>

VisiblePositionTemplate<Strategy> originalBase() const;

- void setOriginalBase(const VisiblePosition& newBase) { m_originalBase = newBase; }

- void setOriginalBase(const VisiblePositionInFlatTree& newBase) { m_originalBaseInFlatTree = newBase; }

+ void setOriginalBase(const VisiblePosition&);

+ void setOriginalBase(const VisiblePositionInFlatTree&);

template <typename Strategy>

void setNonDirectionalSelectionIfNeededAlgorithm(const VisibleSelectionTemplate<Strategy>&, TextGranularity, EndPointsAdjustmentMode);