Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1793093006: [Editing][Stability] Recanonicalize m_originalbase in FrameSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit pick Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 friend class FrameSelectionTest; 251 friend class FrameSelectionTest;
252 252
253 explicit FrameSelection(LocalFrame*); 253 explicit FrameSelection(LocalFrame*);
254 254
255 // Note: We have |selectionInFlatTree()| for unit tests, we should 255 // Note: We have |selectionInFlatTree()| for unit tests, we should
256 // use |visibleSelection<EditingInFlatTreeStrategy>()|. 256 // use |visibleSelection<EditingInFlatTreeStrategy>()|.
257 const VisibleSelectionInFlatTree& selectionInFlatTree() const; 257 const VisibleSelectionInFlatTree& selectionInFlatTree() const;
258 258
259 template <typename Strategy> 259 template <typename Strategy>
260 VisiblePositionTemplate<Strategy> originalBase() const; 260 VisiblePositionTemplate<Strategy> originalBase() const;
261 void setOriginalBase(const VisiblePosition& newBase) { m_originalBase = newB ase; } 261 void setOriginalBase(const VisiblePosition&);
262 void setOriginalBase(const VisiblePositionInFlatTree& newBase) { m_originalB aseInFlatTree = newBase; } 262 void setOriginalBase(const VisiblePositionInFlatTree&);
263 263
264 template <typename Strategy> 264 template <typename Strategy>
265 void setNonDirectionalSelectionIfNeededAlgorithm(const VisibleSelectionTempl ate<Strategy>&, TextGranularity, EndPointsAdjustmentMode); 265 void setNonDirectionalSelectionIfNeededAlgorithm(const VisibleSelectionTempl ate<Strategy>&, TextGranularity, EndPointsAdjustmentMode);
266 266
267 template <typename Strategy> 267 template <typename Strategy>
268 void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&, SetSel ectionOptions, CursorAlignOnScroll, TextGranularity); 268 void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&, SetSel ectionOptions, CursorAlignOnScroll, TextGranularity);
269 269
270 void respondToNodeModification(Node&, bool baseRemoved, bool extentRemoved, bool startRemoved, bool endRemoved); 270 void respondToNodeModification(Node&, bool baseRemoved, bool extentRemoved, bool startRemoved, bool endRemoved);
271 271
272 void notifyAccessibilityForSelectionChange(); 272 void notifyAccessibilityForSelectionChange();
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 } 339 }
340 } // namespace blink 340 } // namespace blink
341 341
342 #ifndef NDEBUG 342 #ifndef NDEBUG
343 // Outside the WebCore namespace for ease of invocation from gdb. 343 // Outside the WebCore namespace for ease of invocation from gdb.
344 void showTree(const blink::FrameSelection&); 344 void showTree(const blink::FrameSelection&);
345 void showTree(const blink::FrameSelection*); 345 void showTree(const blink::FrameSelection*);
346 #endif 346 #endif
347 347
348 #endif // FrameSelection_h 348 #endif // FrameSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698