Check that const-map keys don't override equals.

Check that const-map keys don't override equals.

BUG= http://dartbug.com/17123
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33201

[karlklose, 2014-03-03 08:58:45]

LGTM.

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3103:
List<Constant> keys = map.keys.entries;
You can inline `keys`.

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/warnings.dart:561: "Const-map key
'#{type}' overrides 'operator =='.");
I would say 'Const-map key *type* '#type' ...' (see also
SWITCH_CASE_VALUE_OVERRIDES_EQUALS).

https://codereview.chromium.org/179293005/diff/40001/tests/language/const_map...
File tests/language/const_map2_test.dart (right):

https://codereview.chromium.org/179293005/diff/40001/tests/language/const_map...
tests/language/const_map2_test.dart:23: // It is a compile-time error if the key
overrides operator ==.
'key' -> 'key type'.

[floitsch, 2014-03-03 09:52:32]

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3103:
List<Constant> keys = map.keys.entries;
On 2014/03/03 08:58:45, karlklose wrote:
> You can inline `keys`.

Done.

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/179293005/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/warnings.dart:561: "Const-map key
'#{type}' overrides 'operator =='.");
On 2014/03/03 08:58:45, karlklose wrote:
> I would say 'Const-map key *type* '#type' ...' (see also
> SWITCH_CASE_VALUE_OVERRIDES_EQUALS).

Done.

https://codereview.chromium.org/179293005/diff/40001/tests/language/const_map...
File tests/language/const_map2_test.dart (right):

https://codereview.chromium.org/179293005/diff/40001/tests/language/const_map...
tests/language/const_map2_test.dart:23: // It is a compile-time error if the key
overrides operator ==.
On 2014/03/03 08:58:45, karlklose wrote:
> 'key' -> 'key type'.

Done.

[floitsch, 2014-03-03 09:52:59]

Committed patchset #4 manually as r33201 (presubmit successful).