sdk/lib/_internal/compiler/implementation/warnings.dart - Issue 179293005: Check that const-map keys don't override equals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 179293005: Check that const-map keys don't override equals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/warnings.dart

diff --git a/sdk/lib/_internal/compiler/implementation/warnings.dart b/sdk/lib/_internal/compiler/implementation/warnings.dart

index 8cef76fbfc30e67ba7e4dda467e676eae8bccd91..0b33526621d019b5eb476d8fb2fd61344d3807c3 100644

--- a/sdk/lib/_internal/compiler/implementation/warnings.dart

+++ b/sdk/lib/_internal/compiler/implementation/warnings.dart

@@ -556,8 +556,9 @@ main() => new C<String>();

static const MessageKind CONSTRUCTOR_IS_NOT_CONST = const MessageKind(

"Constructor is not a 'const' constructor.");

- static const MessageKind KEY_NOT_A_STRING_LITERAL = const MessageKind(

- "Map-literal key not a string literal.");

+ static const MessageKind CONST_MAP_KEY_OVERRIDES_EQUALS =

+ const MessageKind(

+ "Const-map key type '#{type}' overrides 'operator =='.");

static const MessageKind NO_SUCH_LIBRARY_MEMBER = const MessageKind(

"'#{libraryName}' has no member named '#{memberName}'.");