Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/app_shim/app_shim_win.gypi

Issue 179223003: Adding app_shim executable on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Automatically get the Chrome binary from the registry instead of taking it on the command line. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app_shim/app_shim_win.gypi
diff --git a/chrome/app_shim/app_shim_win.gypi b/chrome/app_shim/app_shim_win.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..8291b5e4d0b79716e220d791ef71268caef22eaf
--- /dev/null
+++ b/chrome/app_shim/app_shim_win.gypi
@@ -0,0 +1,30 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'targets': [
+ # This is the app shim on Windows. It is a small binary that simply runs
+ # Chrome, passing along any command-line arguments.
+ {
+ 'target_name': 'app_shim_win',
grt (UTC plus 2) 2014/10/30 17:04:56 it seems that this does something completely diffe
Matt Giuca 2014/10/30 21:16:35 It's the same concept: a small shim to run an app
grt (UTC plus 2) 2014/10/31 14:29:59 Ah, I misunderstood what the Mac one does. Thanks
Matt Giuca 2014/11/04 04:38:17 Discussed with Jack (owner of app_shim.gypi); the
grt (UTC plus 2) 2014/11/04 14:04:52 SGTM, thanks.
+ 'type': 'executable',
+ 'include_dirs': [
+ '../..',
grt (UTC plus 2) 2014/10/30 17:04:56 is this necessary?
Matt Giuca 2014/11/04 04:38:17 Apparently not. Deleted.
+ ],
+ 'dependencies': [
+ 'launcher_support',
+ '../base/base.gyp:base',
+ ],
+ 'sources': [
+ 'app_shim_win.cc',
+ 'app_shim_win.rc',
+ ],
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
+ },
+ },
+ },
+ ], # targets
+}

Powered by Google App Engine
This is Rietveld 408576698