Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chrome/app_shim/app_shim_win.gypi

Issue 179223003: Adding app_shim executable on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Automatically get the Chrome binary from the registry instead of taking it on the command line. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 {
6 'targets': [
7 # This is the app shim on Windows. It is a small binary that simply runs
8 # Chrome, passing along any command-line arguments.
9 {
10 'target_name': 'app_shim_win',
grt (UTC plus 2) 2014/10/30 17:04:56 it seems that this does something completely diffe
Matt Giuca 2014/10/30 21:16:35 It's the same concept: a small shim to run an app
grt (UTC plus 2) 2014/10/31 14:29:59 Ah, I misunderstood what the Mac one does. Thanks
Matt Giuca 2014/11/04 04:38:17 Discussed with Jack (owner of app_shim.gypi); the
grt (UTC plus 2) 2014/11/04 14:04:52 SGTM, thanks.
11 'type': 'executable',
12 'include_dirs': [
13 '../..',
grt (UTC plus 2) 2014/10/30 17:04:56 is this necessary?
Matt Giuca 2014/11/04 04:38:17 Apparently not. Deleted.
14 ],
15 'dependencies': [
16 'launcher_support',
17 '../base/base.gyp:base',
18 ],
19 'sources': [
20 'app_shim_win.cc',
21 'app_shim_win.rc',
22 ],
23 'msvs_settings': {
24 'VCLinkerTool': {
25 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
26 },
27 },
28 },
29 ], # targets
30 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698