Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 17911005: Merge 208347 "Revert 208315 "Make use of InvalidationService"" (Closed)

Created:
7 years, 6 months ago by rlarocque
Modified:
7 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Merge 208347 "Revert 208315 "Make use of InvalidationService"" > Revert 208315 "Make use of InvalidationService" > > > Make use of InvalidationService > > > > The InvalidationService was introduced r199520. That commit added the > > InvalidationService interface and several implementations of it, but > > made no use of the new code. This commit builds on that work. > > > > Up until now, TICL invalidations were handled on the sync thread. The > > related objects were instantiated and owned by the SyncBackendHost and > > SyncManager. All requests to update the set of object registrations had > > to be passed to the sync thread. Components that wanted to receive > > invalidations but were not part of sync had to route their communication > > with the invalidations server through ProfileSyncService to get to the > > sync thread. Things were a bit different on Android, but the system > > still tried to pretend that invalidations were owned by the sync thread. > > > > The new InvalidationService implementation is a ProfileKeyedService that > > is mostly independent from sync. It still relies on sync to manage sign > > in and fetch the appropriate auth tokens. However, it's now much easier > > for components outside of sync to communication with the invalidations > > server. > > > > The new system allows us to remove a lot of invalidations-related code > > from the ProfileSyncService, SyncBackendHost and SyncManager. Sync is > > now just one of many clients of the InvalidationService. The > > SyncBackendHost is responsible for forwarding messages back and forth > > between the InvalidationService and the sync thread. > > > > TBR=sky,erg > > BUG=124137 > > > > Review URL: https://chromiumcodereview.appspot.com/15580002 > > TBR=rlarocque@chromium.org > > Review URL: https://codereview.chromium.org/17610004 TBR=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1243 lines, -1384 lines) Patch
M chrome/browser/chrome_to_mobile_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 6 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_notification_manager.cc View 4 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/drive/drive_notification_manager_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 4 chunks +8 lines, -34 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/sync_setup_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/invalidation/fake_invalidation_service.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/invalidation/fake_invalidation_service.cc View 1 chunk +0 lines, -62 lines 0 comments Download
A + chrome/browser/invalidation/invalidation_frontend.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/invalidation/invalidation_frontend_test_template.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/invalidation/invalidation_frontend_test_template.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/invalidation/invalidation_service.h View 1 chunk +0 lines, -114 lines 0 comments Download
M chrome/browser/invalidation/invalidation_service_android.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/invalidation/invalidation_service_android_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/invalidation/invalidation_service_factory.h View 3 chunks +12 lines, -23 lines 0 comments Download
M chrome/browser/invalidation/invalidation_service_factory.cc View 4 chunks +15 lines, -57 lines 0 comments Download
D chrome/browser/invalidation/invalidation_service_test_template.h View 1 chunk +0 lines, -384 lines 0 comments Download
D chrome/browser/invalidation/invalidation_service_test_template.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/invalidation/p2p_invalidation_service.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/invalidation/ticl_invalidation_service.h View 4 chunks +10 lines, -41 lines 0 comments Download
M chrome/browser/invalidation/ticl_invalidation_service.cc View 10 chunks +37 lines, -156 lines 0 comments Download
M chrome/browser/invalidation/ticl_invalidation_service_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +0 lines, -3 lines 0 comments Download
A + chrome/browser/sync/glue/android_invalidator_bridge.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/android_invalidator_bridge.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/android_invalidator_bridge_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/android_invalidator_bridge_proxy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/dummy_invalidator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/sync/glue/dummy_invalidator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 15 chunks +31 lines, -18 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 32 chunks +209 lines, -67 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 4 chunks +76 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 11 chunks +52 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 17 chunks +113 lines, -12 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.h View 5 chunks +8 lines, -24 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 5 chunks +12 lines, -40 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_observer.h View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/sync/profile_sync_service_observer.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 12 chunks +16 lines, -24 lines 0 comments Download
MM chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 6 chunks +179 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 5 chunks +13 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 6 chunks +26 lines, -9 lines 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 4 chunks +18 lines, -3 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 6 chunks +21 lines, -3 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 8 chunks +78 lines, -4 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 9 chunks +61 lines, -1 line 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 5 chunks +56 lines, -8 lines 0 comments Download
M sync/notifier/fake_invalidator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/notifier/fake_invalidator.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/notifier/invalidation_notifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M sync/notifier/invalidator.h View 1 chunk +7 lines, -0 lines 0 comments Download
A + sync/notifier/invalidator_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/notifier/invalidator_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/notifier/invalidator_factory_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M sync/notifier/invalidator_registrar.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/notifier/invalidator_registrar_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sync/notifier/non_blocking_invalidator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/notifier/non_blocking_invalidator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M sync/notifier/p2p_invalidator.h View 3 chunks +2 lines, -5 lines 0 comments Download
M sync/sync_notifier.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/tools/sync_client.cc View 9 chunks +23 lines, -54 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M sync/tools/testserver/xmppserver.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rlarocque
7 years, 6 months ago (2013-06-26 18:02:01 UTC) #1
rlarocque
7 years, 6 months ago (2013-06-26 18:08:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r208733.

Powered by Google App Engine
This is Rietveld 408576698