Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/sync/profile_sync_service_harness.h

Issue 17911005: Merge 208347 "Revert 208315 "Make use of InvalidationService"" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1547/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_harness.h
===================================================================
--- chrome/browser/sync/profile_sync_service_harness.h (revision 208727)
+++ chrome/browser/sync/profile_sync_service_harness.h (working copy)
@@ -18,10 +18,6 @@
class Profile;
-namespace invalidation {
-class P2PInvalidationService;
-}
-
namespace browser_sync {
namespace sessions {
class SyncSessionSnapshot;
@@ -37,19 +33,17 @@
: public ProfileSyncServiceObserver,
public browser_sync::MigrationObserver {
public:
- static ProfileSyncServiceHarness* Create(
- Profile* profile,
- const std::string& username,
- const std::string& password);
+ ProfileSyncServiceHarness(Profile* profile,
+ const std::string& username,
+ const std::string& password);
- static ProfileSyncServiceHarness* CreateForIntegrationTest(
- Profile* profile,
- const std::string& username,
- const std::string& password,
- invalidation::P2PInvalidationService* invalidation_service);
-
virtual ~ProfileSyncServiceHarness();
+ // Creates a ProfileSyncServiceHarness object and attaches it to |profile|, a
+ // profile that is assumed to have been signed into sync in the past. Caller
+ // takes ownership.
+ static ProfileSyncServiceHarness* CreateAndAttach(Profile* profile);
+
// Sets the GAIA credentials with which to sign in to sync.
void SetCredentials(const std::string& username, const std::string& password);
@@ -68,7 +62,6 @@
// ProfileSyncServiceObserver implementation.
virtual void OnStateChanged() OVERRIDE;
- virtual void OnSyncCycleCompleted() OVERRIDE;
// MigrationObserver implementation.
virtual void OnMigrationStateChange() OVERRIDE;
@@ -277,12 +270,6 @@
NUMBER_OF_STATES,
};
- ProfileSyncServiceHarness(
- Profile* profile,
- const std::string& username,
- const std::string& password,
- invalidation::P2PInvalidationService* invalidation_service);
-
// Listen to migration events if the migrator has been initialized
// and we're not already listening. Returns true if we started
// listening.
@@ -347,9 +334,6 @@
// ProfileSyncService object associated with |profile_|.
ProfileSyncService* service_;
- // P2PInvalidationService associated with |profile_|.
- invalidation::P2PInvalidationService* p2p_invalidation_service_;
-
// The harness of the client whose update progress marker we're expecting
// eventually match.
ProfileSyncServiceHarness* progress_marker_partner_;
« no previous file with comments | « chrome/browser/sync/profile_sync_service_factory.cc ('k') | chrome/browser/sync/profile_sync_service_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698