Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1790993002: Skip logging spurious errors for ServiceWorker URLRequests that were spawned (Closed)

Created:
4 years, 9 months ago by lazyboy
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip logging spurious errors for ServiceWorker URLRequests that were spawned through ServiceWorkerWriteToCacheJob. This CL does not fix the underlying issue, it is just suppressing a not so useful error log. BUG=568788 Test=Load an extension page with ServiceWorker, observe no "Allowing load of ..." error messages anymore. Committed: https://crrev.com/16b16fba24fa3cac9e5c852cb707a5317c34ddad Cr-Commit-Position: refs/heads/master@{#381517}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments from asargent@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M extensions/browser/extension_protocols.cc View 1 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
falken
lgtm
4 years, 9 months ago (2016-03-14 00:49:58 UTC) #2
lazyboy
+asargent for OWNERS review.
4 years, 9 months ago (2016-03-15 11:02:59 UTC) #4
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/1790993002/diff/1/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/1790993002/diff/1/extensions/browser/extension_protocols.cc#newcode333 extensions/browser/extension_protocols.cc:333: // does not have ResourceRequestInfo associated with them. ...
4 years, 9 months ago (2016-03-15 16:41:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790993002/20001
4 years, 9 months ago (2016-03-16 19:47:55 UTC) #8
lazyboy
https://codereview.chromium.org/1790993002/diff/1/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/1790993002/diff/1/extensions/browser/extension_protocols.cc#newcode333 extensions/browser/extension_protocols.cc:333: // does not have ResourceRequestInfo associated with them. So ...
4 years, 9 months ago (2016-03-16 19:48:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 20:10:02 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:11:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16b16fba24fa3cac9e5c852cb707a5317c34ddad
Cr-Commit-Position: refs/heads/master@{#381517}

Powered by Google App Engine
This is Rietveld 408576698