Skip logging spurious errors for ServiceWorker URLRequests that were spawned

extensions/browser/extension_protocols.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_protocols.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 311 matching lines @@
 // TODO(aa): This should be moved into ExtensionResourceRequestPolicy, but we
 // first need to find a way to get CanLoadInIncognito state into the renderers.
 bool AllowExtensionResourceLoad(net::URLRequest* request,
                                 bool is_incognito,
                                 const Extension* extension,
                                 extensions::InfoMap* extension_info_map) {
   const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
 
   // We have seen crashes where info is NULL: crbug.com/52374.
   if (!info) {
-    LOG(ERROR) << "Allowing load of " << request->url().spec()
-               << "from unknown origin. Could not find user data for "
-               << "request.";
+    // SeviceWorker net requests created through ServiceWorkerWriteToCacheJob
+    // does not have ResourceRequestInfo associated with them. So skip logging

[asargent_no_longer_on_chrome, 2016/03/15 16:41:29]

grammar nit: should be "... do not have..."

[lazyboy, 2016/03/16 19:48:25]

Done.

+    // spurious errors below.
+    // TODO(falken): Either consider attaching ResourceRequestInfo to these or
+    // finish refactoring ServiceWorkerWriteToCacheJob so that it doesn't spawn
+    // a new URLRequest.
+    if (!ResourceRequestInfo::OriginatedFromServiceWorker(request)) {
+      LOG(ERROR) << "Allowing load of " << request->url().spec()
+                 << "from unknown origin. Could not find user data for "
+                 << "request.";
+    }
     return true;
   }
 
   if (is_incognito && !ExtensionCanLoadInIncognito(
                           info, request->url().host(), extension_info_map)) {
     return false;
   }
 
   // The following checks are meant to replicate similar set of checks in the
   // renderer process, performed by ResourceRequestPolicy::CanRequestResource.
@@ skipping 223 matching lines @@
 }
 
 scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>
 CreateExtensionProtocolHandler(bool is_incognito,
                                extensions::InfoMap* extension_info_map) {
   return make_scoped_ptr(
       new ExtensionProtocolHandler(is_incognito, extension_info_map));
 }
 
 }  // namespace extensions