Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 17909002: Exposing Node.firstChild and Node.lastChild. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/safe_dom_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 0cc1570b2845e9a5b94389f4d7f91853ba3bb849..2fdec062059f14efe71b56d6783f97c55c2ad0dd 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -17523,12 +17523,12 @@ class _ChildNodeListLazy extends ListBase<Node> {
Node get first {
- Node result = _this.$dom_firstChild;
+ Node result = _this.firstChild;
if (result == null) throw new StateError("No elements");
return result;
}
Node get last {
- Node result = _this.$dom_lastChild;
+ Node result = _this.lastChild;
if (result == null) throw new StateError("No elements");
return result;
}
@@ -17536,7 +17536,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
int l = this.length;
if (l == 0) throw new StateError("No elements");
if (l > 1) throw new StateError("More than one element");
- return _this.$dom_firstChild;
+ return _this.firstChild;
}
void add(Node value) {
@@ -17549,8 +17549,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
if (!identical(otherList._this, _this)) {
// Optimized route for copying between nodes.
for (var i = 0, len = otherList.length; i < len; ++i) {
- // Should use $dom_firstChild, Bug 8886.
- _this.append(otherList[0]);
+ _this.append(otherList._this.firstChild);
}
}
return;
@@ -17608,7 +17607,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
// This implementation of removeWhere/retainWhere is more efficient
// than the default in ListBase. Child nodes can be removed in constant
// time.
- Node child = _this.$dom_firstChild;
+ Node child = _this.firstChild;
while (child != null) {
Node nextChild = child.nextNode;
if (test(child) == removeMatching) {
@@ -17726,8 +17725,7 @@ class Node extends EventTarget {
// Optimized route for copying between nodes.
for (var i = 0, len = otherList.length; i < len; ++i) {
- // Should use $dom_firstChild, Bug 8886.
- this.insertBefore(otherList[0], refChild);
+ this.insertBefore(otherList._this.firstChild, refChild);
}
} else {
for (var node in newNodes) {
@@ -17824,11 +17822,11 @@ class Node extends EventTarget {
@DomName('Node.firstChild')
@DocsEditable
- Node get $dom_firstChild native "Node_firstChild_Getter";
+ Node get firstChild native "Node_firstChild_Getter";
@DomName('Node.lastChild')
@DocsEditable
- Node get $dom_lastChild native "Node_lastChild_Getter";
+ Node get lastChild native "Node_lastChild_Getter";
@DomName('Node.localName')
@DocsEditable
@@ -30068,7 +30066,7 @@ class _Bindings {
}
}
- for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
+ for (var c = node.firstChild; c != null; c = c.nextNode) {
clone.append(_createDeepCloneAndDecorateTemplates(c, syntax));
}
return clone;
@@ -30084,8 +30082,8 @@ class _Bindings {
// TODO(arv): This should either be a Document or HTMLDocument depending
// on doc.
d = doc.implementation.createHtmlDocument('');
- while (d.$dom_lastChild != null) {
- d.$dom_lastChild.remove();
+ while (d.lastChild != null) {
+ d.lastChild.remove();
}
doc._templateContentsOwner = d;
}
@@ -30117,7 +30115,7 @@ class _Bindings {
if (!templateElement._isAttributeTemplate) {
var child;
- while ((child = templateElement.$dom_firstChild) != null) {
+ while ((child = templateElement.firstChild) != null) {
content.append(child);
}
return;
@@ -30136,7 +30134,7 @@ class _Bindings {
//
var newRoot = _cloneAndSeperateAttributeTemplate(templateElement);
var child;
- while ((child = templateElement.$dom_firstChild) != null) {
+ while ((child = templateElement.firstChild) != null) {
newRoot.append(child);
}
content.append(newRoot);
@@ -30168,7 +30166,7 @@ class _Bindings {
_parseAndBind(node, 'text', node.text, model, syntax);
}
- for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
+ for (var c = node.firstChild; c != null; c = c.nextNode) {
_addBindings(c, model, syntax);
}
}
@@ -30284,12 +30282,12 @@ class _Bindings {
}
static void _addTemplateInstanceRecord(fragment, model) {
- if (fragment.$dom_firstChild == null) {
+ if (fragment.firstChild == null) {
return;
}
var instanceRecord = new TemplateInstance(
- fragment.$dom_firstChild, fragment.$dom_lastChild, model);
+ fragment.firstChild, fragment.lastChild, model);
var node = instanceRecord.firstNode;
while (node != null) {
@@ -30300,7 +30298,7 @@ class _Bindings {
static void _removeAllBindingsRecursively(Node node) {
_nodeOrCustom(node).unbindAll();
- for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
+ for (var c = node.firstChild; c != null; c = c.nextNode) {
_removeAllBindingsRecursively(c);
}
}
@@ -30390,7 +30388,7 @@ class _TemplateIterator {
void insertInstanceAt(int index, Node fragment) {
var previousTerminator = getTerminatorAt(index - 1);
- var terminator = fragment.$dom_lastChild;
+ var terminator = fragment.lastChild;
if (terminator == null) terminator = previousTerminator;
terminators.insert(index, terminator);
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/safe_dom_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698