Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 17909002: Exposing Node.firstChild and Node.lastChild. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 116b28dfc19ca1a2e022b59ab0224e24c0580572..e51553efc4e5d7ea1e619c649fe10b0c2c25f964 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -16367,8 +16367,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
if (!identical(otherList._this, _this)) {
// Optimized route for copying between nodes.
for (var i = 0, len = otherList.length; i < len; ++i) {
- // Should use $dom_firstChild, Bug 8886.
- _this.append(otherList[0]);
+ _this.append(otherList._this.firstChild);
}
}
return;
@@ -16426,7 +16425,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
// This implementation of removeWhere/retainWhere is more efficient
// than the default in ListBase. Child nodes can be removed in constant
// time.
- Node child = _this.$dom_firstChild;
+ Node child = _this.firstChild;
while (child != null) {
Node nextChild = child.nextNode;
if (test(child) == removeMatching) {
@@ -16544,8 +16543,7 @@ class Node extends EventTarget native "Node" {
// Optimized route for copying between nodes.
for (var i = 0, len = otherList.length; i < len; ++i) {
- // Should use $dom_firstChild, Bug 8886.
- this.insertBefore(otherList[0], refChild);
+ this.insertBefore(otherList._this.firstChild, refChild);
}
} else {
for (var node in newNodes) {
@@ -16642,15 +16640,13 @@ class Node extends EventTarget native "Node" {
@Creates('NodeList')
final List<Node> $dom_childNodes;
- @JSName('firstChild')
@DomName('Node.firstChild')
@DocsEditable
- final Node $dom_firstChild;
+ final Node firstChild;
- @JSName('lastChild')
@DomName('Node.lastChild')
@DocsEditable
- final Node $dom_lastChild;
+ final Node lastChild;
@JSName('localName')
@DomName('Node.localName')
@@ -28065,7 +28061,7 @@ class _Bindings {
}
}
- for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
+ for (var c = node.firstChild; c != null; c = c.nextNode) {
clone.append(_createDeepCloneAndDecorateTemplates(c, syntax));
}
return clone;
@@ -28081,8 +28077,8 @@ class _Bindings {
// TODO(arv): This should either be a Document or HTMLDocument depending
// on doc.
d = doc.implementation.createHtmlDocument('');
- while (d.$dom_lastChild != null) {
- d.$dom_lastChild.remove();
+ while (d.lastChild != null) {
+ d.lastChild.remove();
}
doc._templateContentsOwner = d;
}
@@ -28114,7 +28110,7 @@ class _Bindings {
if (!templateElement._isAttributeTemplate) {
var child;
- while ((child = templateElement.$dom_firstChild) != null) {
+ while ((child = templateElement.firstChild) != null) {
content.append(child);
}
return;
@@ -28133,7 +28129,7 @@ class _Bindings {
//
var newRoot = _cloneAndSeperateAttributeTemplate(templateElement);
var child;
- while ((child = templateElement.$dom_firstChild) != null) {
+ while ((child = templateElement.firstChild) != null) {
newRoot.append(child);
}
content.append(newRoot);
@@ -28165,7 +28161,7 @@ class _Bindings {
_parseAndBind(node, 'text', node.text, model, syntax);
}
- for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
+ for (var c = node.firstChild; c != null; c = c.nextNode) {
_addBindings(c, model, syntax);
}
}
@@ -28281,12 +28277,12 @@ class _Bindings {
}
static void _addTemplateInstanceRecord(fragment, model) {
- if (fragment.$dom_firstChild == null) {
+ if (fragment.firstChild == null) {
return;
}
var instanceRecord = new TemplateInstance(
- fragment.$dom_firstChild, fragment.$dom_lastChild, model);
+ fragment.firstChild, fragment.lastChild, model);
var node = instanceRecord.firstNode;
while (node != null) {
@@ -28297,7 +28293,7 @@ class _Bindings {
static void _removeAllBindingsRecursively(Node node) {
_nodeOrCustom(node).unbindAll();
- for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
+ for (var c = node.firstChild; c != null; c = c.nextNode) {
_removeAllBindingsRecursively(c);
}
}
@@ -28387,7 +28383,7 @@ class _TemplateIterator {
void insertInstanceAt(int index, Node fragment) {
var previousTerminator = getTerminatorAt(index - 1);
- var terminator = fragment.$dom_lastChild;
+ var terminator = fragment.lastChild;
if (terminator == null) terminator = previousTerminator;
terminators.insert(index, terminator);
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698