Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2934)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1790663003: Fix for flash fullscreen animations on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index dbaec96b2af949a9b550586a29dceabfcfc65425..ebb3bd4f108bc7b2d6d7d13a286aa63e0e570e3e 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -1139,11 +1139,6 @@ willPositionSheet:(NSWindow*)sheet
if (base::mac::IsOSMavericks() && !enterFullScreen)
return NO;
- // TODO(spqchan): Fix Flash fullscreen animation in popups.
- // See http://crbug.com/566588.
- if ([self isFullscreenForTabContent] && browser_->is_type_popup())
- return NO;
-
NSView* root = [[self.window contentView] superview];
if (!root.layer)
return NO;
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698