Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 179051: Fix two issues with the plugin installer.... (Closed)

Created:
11 years, 3 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Fix two issues with the plugin installer. The first is that we weren't reloading the pages with plugins. The second is that there was a InstallerDialog instance per plugin object on the page. On a page like nytimes.com that creates and destroys a Flash object on loading, this meant that if the user clicked on the plugin/infobar inbetween, the dialog would show up and then get hidden abruptly. TEST=go to nytimes.com on a machine without Flash installed and click the infobar as soon as it shows up. BUG=20690 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24995

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -43 lines) Patch
M webkit/api/src/WebKit.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/install_dialog.h View 3 chunks +15 lines, -12 lines 0 comments Download
M webkit/default_plugin/install_dialog.cc View 1 2 3 chunks +52 lines, -22 lines 0 comments Download
M webkit/default_plugin/plugin_impl_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/default_plugin/plugin_impl_win.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
11 years, 3 months ago (2009-08-31 22:54:57 UTC) #1
ananta
LGTM http://codereview.chromium.org/179051/diff/3001/4003 File webkit/default_plugin/install_dialog.cc (right): http://codereview.chromium.org/179051/diff/3001/4003#newcode15 Line 15: static DialogMap* s_dialogs; Should we use LazyInstance ...
11 years, 3 months ago (2009-09-01 00:11:13 UTC) #2
jam
http://codereview.chromium.org/179051/diff/3001/4003 File webkit/default_plugin/install_dialog.cc (right): http://codereview.chromium.org/179051/diff/3001/4003#newcode15 Line 15: static DialogMap* s_dialogs; On 2009/09/01 00:11:14, ananta wrote: ...
11 years, 3 months ago (2009-09-01 00:36:13 UTC) #3
ananta
11 years, 3 months ago (2009-09-01 00:40:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698