Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: webkit/default_plugin/install_dialog.h

Issue 179051: Fix two issues with the plugin installer.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/api/src/WebKit.cpp ('k') | webkit/default_plugin/install_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/default_plugin/install_dialog.h
===================================================================
--- webkit/default_plugin/install_dialog.h (revision 24950)
+++ webkit/default_plugin/install_dialog.h (working copy)
@@ -8,6 +8,7 @@
#include <atlbase.h>
#include <atlwin.h>
#include <string>
+#include <vector>
#include "webkit/default_plugin/default_plugin_resources.h"
@@ -18,11 +19,6 @@
// where it would be downloaded from, etc.
class PluginInstallDialog : public CDialogImpl<PluginInstallDialog> {
public:
- PluginInstallDialog()
- : plugin_impl_(NULL) {
- }
- ~PluginInstallDialog() {}
-
enum {IDD = IDD_DEFAULT_PLUGIN_INSTALL_DIALOG};
BEGIN_MSG_MAP(PluginInstallDialog)
@@ -31,26 +27,33 @@
COMMAND_ID_HANDLER(IDCANCEL, OnCancel)
END_MSG_MAP()
- bool Initialize(PluginInstallerImpl* plugin_impl,
- const std::wstring& plugin_name);
+ // Creates or returns the existing object for the given plugin name.
+ // Call RemoveInstaller when done.
+ static PluginInstallDialog* AddInstaller(PluginInstallerImpl* plugin_impl,
+ const std::wstring& plugin_name);
+ // Lets this object know that the given installer object is going away.
+ void RemoveInstaller(PluginInstallerImpl* installer);
+
+ void ShowInstallDialog();
+
+ private:
+ PluginInstallDialog(const std::wstring& plugin_name);
+ ~PluginInstallDialog();
+
// Implemented to ensure that we handle RTL layouts correctly.
HWND Create(HWND parent_window, LPARAM init_param);
- protected:
LRESULT OnInitDialog(UINT message, WPARAM wparam, LPARAM lparam,
BOOL& handled);
LRESULT OnGetPlugin(WORD notify_code, WORD id, HWND wnd_ctl, BOOL &handled);
LRESULT OnCancel(WORD notify_code, WORD id, HWND wnd_ctl, BOOL &handled);
- // Determines whether the UI layout is right-to-left.
- bool IsRTLLayout() const;
-
// Wraps the string with Unicode directionality characters in order to make
// sure BiDi text is rendered correctly when the UI layout is right-to-left.
void AdjustTextDirectionality(std::wstring* text) const;
- PluginInstallerImpl* plugin_impl_;
+ std::vector<PluginInstallerImpl*> installers_;
std::wstring plugin_name_;
};
« no previous file with comments | « webkit/api/src/WebKit.cpp ('k') | webkit/default_plugin/install_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698