Chromium Code Reviews| Index: gyp/SampleApp.gyp |
| =================================================================== |
| --- gyp/SampleApp.gyp (revision 9765) |
| +++ gyp/SampleApp.gyp (working copy) |
| @@ -1,4 +1,10 @@ |
| { |
| + 'variables': { |
| + 'sample_pdf_file_viewer%': 0, |
| + # set sample_pdf_file_viewer to 1 and uncomment next line too, |
| + # podofo dependency has plentry od warnings in the header files that will be errors otherwise |
|
vandebo (ex-Chrome)
2013/06/26 18:45:26
typo: od => of
edisonn
2013/06/26 18:52:30
Done.
|
| + #'skia_warnings_as_errors': 0, |
|
vandebo (ex-Chrome)
2013/06/26 18:45:26
Can't you just set this in the podofo build target
edisonn
2013/06/26 18:52:30
it is done, but there are warnings in the public .
|
| + }, |
| 'targets': [ |
| { |
| 'target_name': 'SampleApp', |
| @@ -151,7 +157,25 @@ |
| 'views_animated.gyp:views_animated', |
| 'lua.gyp:lua', |
| ], |
| - 'conditions' : [ |
| + 'conditions' : [ |
| + [ 'sample_pdf_file_viewer == 1', { |
| + 'defines': [ |
| + 'SAMPLE_PDF_FILE_VIEWER', |
| + ], |
| + 'dependencies': [ |
| + 'pdfviewer.gyp:libpdfviewer', |
| + ], |
| + 'include_dirs' : [ |
| + '../third_party/externals/podofo/src/base', |
| + '../third_party/externals/podofo/src', |
| + '../third_party/externals/podofo', |
| + '../experimental/PdfViewer', |
| + '../experimental/PdfViewer/autogen', |
| + ], |
| + 'sources': [ |
| + '../samplecode/SamplePdfFileViewer.cpp', |
| + ] |
| + }], |
| [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "chromeos"]', { |
| 'sources!': [ |
| '../samplecode/SampleDecode.cpp', |