Add an option to have a PdfViewer in SampleApp. Add a parameter --pdfDir to pass the dir with pdfs.…

gyp/SampleApp.gyp

 {
+  'variables': {
+    'sample_pdf_file_viewer%': 0,
+    # set sample_pdf_file_viewer to 1 and uncomment next line too,
+    # podofo dependency has plentry od warnings in the header files that will be errors otherwise

[vandebo (ex-Chrome), 2013/06/26 18:45:26]

typo: od => of

[edisonn, 2013/06/26 18:52:30]

Done.

+    #'skia_warnings_as_errors': 0,

[vandebo (ex-Chrome), 2013/06/26 18:45:26]

Can't you just set this in the podofo build target?

[edisonn, 2013/06/26 18:52:30]

it is done, but there are warnings in the public .h headers, so any project that
uses them will end up with a warning

I will try to get rid of podofo in the next week

+  },
   'targets': [
     {
       'target_name': 'SampleApp',
       'type': 'executable',
       'mac_bundle' : 1,
       'include_dirs' : [
         '../src/core',
         '../src/effects', #needed for BlurMask.h
         '../gm',       # needed to pull gm.h
         '../samplecode', # To pull SampleApp.h and SampleCode.h
@@ skipping 132 matching lines @@
       'dependencies': [
         'skia_lib.gyp:skia_lib',
         'views.gyp:views',
         'animator.gyp:animator',
         'xml.gyp:xml',
         'experimental.gyp:experimental',
         'pdf.gyp:pdf',
         'views_animated.gyp:views_animated',
         'lua.gyp:lua',
       ],
-      'conditions' : [
+     'conditions' : [
+       [ 'sample_pdf_file_viewer == 1', {
+         'defines': [
+           'SAMPLE_PDF_FILE_VIEWER',
+         ],
+         'dependencies': [
+           'pdfviewer.gyp:libpdfviewer',
+         ],
+         'include_dirs' : [
+           '../third_party/externals/podofo/src/base',
+           '../third_party/externals/podofo/src',
+           '../third_party/externals/podofo',
+           '../experimental/PdfViewer',
+           '../experimental/PdfViewer/autogen',
+         ],
+         'sources': [
+           '../samplecode/SamplePdfFileViewer.cpp',
+         ]
+       }],      
        [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "chromeos"]', {
          'sources!': [
             '../samplecode/SampleDecode.cpp',
          ],
         }],
         [ 'skia_os == "win"', {
           'sources!': [
             # require UNIX functions
             '../samplecode/SampleEncode.cpp',
           ],
@@ skipping 142 matching lines @@
       },
     },
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: