Chromium Code Reviews
DescriptionFix issue 20297: Typing backspace while in a form field causes the browser to go back in its history
With the changes made in CL http://codereview.chromium.org/173344, gtk_window_activate_key() is used to handle a key event that was not handled by webkit. Unlike the old code, gtk_window_activate_key() may match the key event with predefined accelerators according to its hardware_keycode rather than keyval. Thus, we need to set hardare_keycode to an invalid value in GtkIMContextWrapper if the key event is handled by IME, to prevent BrowserWindowGtk from handling it again.
BUG=20297
: Typing backspace while in a form field causes the browser to go back in its history
TEST=Starts scim's XIM server by running "scim -d", then runs chrome with GTK_IM_MODULE=xim. Open www.google.com and press backspace in the search box, the browser shall not go back to previous page.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24719
Patch Set 1 #Patch Set 2 : '' #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||