Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 179016: Fix issue 20297: Typing backspace while in a form field causes the browser to... (Closed)

Created:
11 years, 3 months ago by James Su
Modified:
9 years, 7 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)
Visibility:
Public.

Description

Fix issue 20297: Typing backspace while in a form field causes the browser to go back in its history With the changes made in CL http://codereview.chromium.org/173344, gtk_window_activate_key() is used to handle a key event that was not handled by webkit. Unlike the old code, gtk_window_activate_key() may match the key event with predefined accelerators according to its hardware_keycode rather than keyval. Thus, we need to set hardare_keycode to an invalid value in GtkIMContextWrapper if the key event is handled by IME, to prevent BrowserWindowGtk from handling it again. BUG=20297 : Typing backspace while in a form field causes the browser to go back in its history TEST=Starts scim's XIM server by running "scim -d", then runs chrome with GTK_IM_MODULE=xim. Open www.google.com and press backspace in the search box, the browser shall not go back to previous page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24719

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/renderer_host/gtk_im_context_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Su
Please help review this single line CL :-) Regards James Su
11 years, 3 months ago (2009-08-28 03:04:27 UTC) #1
Hironori Bono
11 years, 3 months ago (2009-08-28 03:38:22 UTC) #2
LGTM.
Thank you for this fix.

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698