Issue 173344: Improves key event handing code of BrowserWindowGtk....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173344: Improves key event handing code of BrowserWindowGtk.... (Closed)

Created:
11 years, 4 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Hironori Bono, Evan Stade

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Improves key event handing code of BrowserWindowGtk. This CL improves the key event handing code of BrowserWindowGtk. Issue 20118 is also fixed. BUG=20118 : Typing a colon (:) into the address bar causes the browser to freeze TEST=Run chrome with a XIM input method, chrome and x server's cpu usage shall be very low after pressing shift key (or any other modifier key) in omnibox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24422

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -96 lines)			Patch
M	chrome/browser/gtk/browser_window_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	2 chunks	+25 lines, -7 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	2 chunks	+1 line, -88 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Su

(Please ignore CL 174393 and review this one. So weird that gcl created two different ...

11 years, 4 months ago (2009-08-25 10:16:34 UTC) #1

Evan Stade

ok, I think I kind of understand what is going on. Can you change the ...

11 years, 4 months ago (2009-08-25 18:40:37 UTC) #2

James Su

11 years, 4 months ago (2009-08-26 00:41:26 UTC) #3

On 2009/08/25 18:40:37, Evan Stade wrote:
> ok, I think I kind of understand what is going on. Can you change the name of
> HandleAccelerator to something more descriptive since it is no longer just
> handling accelerators but also bindings? with that, LGTM

Any suggestion to the name? How about just HandleKeyboardEvent?

Expand Messages | Collapse Messages