src/ia32/ic-ia32.cc - Issue 17895002: The check for internalized strings relied on the fact that we had less

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 17895002: The check for internalized strings relied on the fact that we had less (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: More comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index 2e270979f26ec6f4db8cbae6542d7b848c470ef2..10d6c863ca726db13bfcbb38d508ab0d894f8cc0 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -317,7 +317,8 @@ static void GenerateKeyNameCheck(MacroAssembler* masm,

__ test(hash, Immediate(Name::kContainsCachedArrayIndexMask));

__ j(zero, index_string);

- // Is the string internalized?

+ // Is the string internalized? We already know it's a string so a single

+ // bit test is enough.

STATIC_ASSERT(kInternalizedTag != 0);

__ test_b(FieldOperand(map, Map::kInstanceTypeOffset), kIsInternalizedMask);

__ j(zero, not_unique);

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »