Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 17895002: The check for internalized strings relied on the fact that we had less (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 __ CmpObjectType(key, LAST_UNIQUE_NAME_TYPE, map); 310 __ CmpObjectType(key, LAST_UNIQUE_NAME_TYPE, map);
311 __ j(above, not_unique); 311 __ j(above, not_unique);
312 STATIC_ASSERT(LAST_UNIQUE_NAME_TYPE == FIRST_NONSTRING_TYPE); 312 STATIC_ASSERT(LAST_UNIQUE_NAME_TYPE == FIRST_NONSTRING_TYPE);
313 __ j(equal, &unique); 313 __ j(equal, &unique);
314 314
315 // Is the string an array index, with cached numeric value? 315 // Is the string an array index, with cached numeric value?
316 __ mov(hash, FieldOperand(key, Name::kHashFieldOffset)); 316 __ mov(hash, FieldOperand(key, Name::kHashFieldOffset));
317 __ test(hash, Immediate(Name::kContainsCachedArrayIndexMask)); 317 __ test(hash, Immediate(Name::kContainsCachedArrayIndexMask));
318 __ j(zero, index_string); 318 __ j(zero, index_string);
319 319
320 // Is the string internalized? 320 // Is the string internalized? We already know it's a string so a single
321 // bit test is enough.
321 STATIC_ASSERT(kInternalizedTag != 0); 322 STATIC_ASSERT(kInternalizedTag != 0);
322 __ test_b(FieldOperand(map, Map::kInstanceTypeOffset), kIsInternalizedMask); 323 __ test_b(FieldOperand(map, Map::kInstanceTypeOffset), kIsInternalizedMask);
323 __ j(zero, not_unique); 324 __ j(zero, not_unique);
324 325
325 __ bind(&unique); 326 __ bind(&unique);
326 } 327 }
327 328
328 329
329 static Operand GenerateMappedArgumentsLookup(MacroAssembler* masm, 330 static Operand GenerateMappedArgumentsLookup(MacroAssembler* masm,
330 Register object, 331 Register object,
(...skipping 1379 matching lines...) Expand 10 before | Expand all | Expand 10 after
1710 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1711 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1711 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1712 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1712 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1713 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1713 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1714 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1714 } 1715 }
1715 1716
1716 1717
1717 } } // namespace v8::internal 1718 } } // namespace v8::internal
1718 1719
1719 #endif // V8_TARGET_ARCH_IA32 1720 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698