Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issue 1789443002: Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://c… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1778393002/ )" Fix was to call get() instead of release() when passing the sp to a bare-ptr method. This reverts commit e683c56115a210b5993df9294260bb147b408bfa. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1789443002 TBR= Committed: https://skia.googlesource.com/skia/+/7fb4f8bd031eda87e1da9bc0f749968c0e872e6f

Patch Set 1 #

Patch Set 2 : use get, not release, when calling legacy function that wants ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -148 lines) Patch
M include/core/SkImage.h View 9 chunks +66 lines, -34 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/c/sk_surface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPictureShader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/image/SkImage.cpp View 1 8 chunks +91 lines, -19 lines 0 comments Download
M src/image/SkImagePriv.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Generator.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 7 chunks +33 lines, -31 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 7 chunks +28 lines, -29 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkBitmapSourceDeserializer.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789443002/20001
4 years, 9 months ago (2016-03-11 12:20:18 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 12:33:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7fb4f8bd031eda87e1da9bc0f749968c0e872e6f

Powered by Google App Engine
This is Rietveld 408576698