src/image/SkImage_Gpu.h - Issue 1789443002: Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage_Gpu.h

Issue 1789443002: Revert "Revert of add Make variations to return SkImage by sk_sp (patchset #5 id:80001 of https://c… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: use get, not release, when calling legacy function that wants ptr Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/image/SkImage_Gpu.h

diff --git a/src/image/SkImage_Gpu.h b/src/image/SkImage_Gpu.h

index c640322a6531cebaa15e96424e43311da7251487..8f59af14a4681d9225f6d5220aaf0bf334652e20 100644

--- a/src/image/SkImage_Gpu.h

+++ b/src/image/SkImage_Gpu.h

@@ -35,7 +35,7 @@ public:

bool getROPixels(SkBitmap*, CachingHint) const override;

GrTexture* asTextureRef(GrContext* ctx, const GrTextureParams& params) const override;

- SkImage* onNewSubset(const SkIRect&) const override;

+ sk_sp<SkImage> onMakeSubset(const SkIRect&) const override;

GrTexture* peekTexture() const override { return fTexture; }

bool isOpaque() const override;

« no previous file with comments | « src/image/SkImage_Generator.cpp ('k') | src/image/SkImage_Gpu.cpp » ('j') | no next file with comments »