Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178943004: Rename tools/perf/metrics/io.py to resolve naming conflicts. (Closed)

Created:
6 years, 9 months ago by bolian
Modified:
6 years, 9 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename tools/perf/metrics/io.py to resolve naming conflicts. BUG=349610 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255303

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments. #

Patch Set 3 : upload again after failed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -63 lines) Patch
M tools/perf/measurements/page_cycler.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
D tools/perf/metrics/io.py View 1 chunk +0 lines, -61 lines 0 comments Download
A + tools/perf/metrics/iometric.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bolian
As mentioned in the bug, io.py prevents others in tools/perf/metrics from doing, for example, "from ...
6 years, 9 months ago (2014-03-05 22:20:39 UTC) #1
tonyg
https://codereview.chromium.org/178943004/diff/1/tools/perf/measurements/page_cycler.py File tools/perf/measurements/page_cycler.py (right): https://codereview.chromium.org/178943004/diff/1/tools/perf/measurements/page_cycler.py#newcode22 tools/perf/measurements/page_cycler.py:22: from metrics import iometric as io Let's do the ...
6 years, 9 months ago (2014-03-05 22:56:26 UTC) #2
bolian
Thanks! https://codereview.chromium.org/178943004/diff/1/tools/perf/measurements/page_cycler.py File tools/perf/measurements/page_cycler.py (right): https://codereview.chromium.org/178943004/diff/1/tools/perf/measurements/page_cycler.py#newcode22 tools/perf/measurements/page_cycler.py:22: from metrics import iometric as io On 2014/03/05 ...
6 years, 9 months ago (2014-03-05 23:07:30 UTC) #3
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 9 months ago (2014-03-05 23:24:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/178943004/40001
6 years, 9 months ago (2014-03-05 23:31:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/178943004/40001
6 years, 9 months ago (2014-03-06 00:17:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/178943004/40001
6 years, 9 months ago (2014-03-06 02:51:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/178943004/40001
6 years, 9 months ago (2014-03-06 03:16:38 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:47:43 UTC) #9
Message was sent while issue was closed. 
Change committed as 255303

Powered by Google App Engine
This is Rietveld 408576698