tools/perf/measurements/page_cycler.py - Issue 178943004: Rename tools/perf/metrics/io.py to resolve naming conflicts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 178943004: Rename tools/perf/metrics/io.py to resolve naming conflicts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: upload again after failed Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index 3c783ddf1ca8a109cfe0234cbd9944b89e3f8359..4757df861e07e1dcd566dbda6619fd944bc413f4 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -19,7 +19,7 @@ import collections

import os

from metrics import cpu

-from metrics import io

+from metrics import iometric

from metrics import memory

from metrics import power

from metrics import speedindex

@@ -98,7 +98,7 @@ class PageCycler(page_measurement.PageMeasurement):

def CustomizeBrowserOptions(self, options):

memory.MemoryMetric.CustomizeBrowserOptions(options)

power.PowerMetric.CustomizeBrowserOptions(options)

- io.IOMetric.CustomizeBrowserOptions(options)

+ iometric.IOMetric.CustomizeBrowserOptions(options)

options.AppendExtraBrowserArgs('--js-flags=--expose_gc')

if options.v8_object_stats:

@@ -172,7 +172,7 @@ class PageCycler(page_measurement.PageMeasurement):

tab, results, chart_name=chart_name_prefix+'speed_index')

def DidRunTest(self, browser, results):

- io.IOMetric().AddSummaryResults(browser, results)

+ iometric.IOMetric().AddSummaryResults(browser, results)

def IsRunCold(self, url):

return (self.ShouldRunCold(url) or

« no previous file with comments | « no previous file | tools/perf/metrics/io.py » ('j') | no next file with comments »