Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Issue 17894005: Merge 152980 "CSS clip should not be considered when clamping fo..." (Closed)

Created:
7 years, 6 months ago by shawnsingh
Modified:
7 years, 6 months ago
Reviewers:
shawnsingh
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Merge 152980 "CSS clip should not be considered when clamping fo..." > CSS clip should not be considered when clamping for overflow clip. > > Previous patch in webkit rev 152919 partially fixed this, but skipped one code > path that still needed fixing. These code paths are intended to clamp the > backgroundRect to the borderBox, or a slightly inflated borderBox. It is > incorrect to trigger those code paths when there is only CSS clip and no > overflow clip. Fixing this bug also results in a tiny refactor where the CSS > clip if-statement is separated from the overflow clip chunks of code. > > BUG=246728 > R=esprehn@chromium.org > > Review URL: https://codereview.chromium.org/17653002 TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
A + LayoutTests/compositing/geometry/clip-with-shadow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/geometry/clip-with-shadow-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 3 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
shawnsingh
7 years, 6 months ago (2013-06-26 18:12:42 UTC) #1
shawnsingh
7 years, 6 months ago (2013-06-26 18:13:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r153084.

Powered by Google App Engine
This is Rietveld 408576698