Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 17653002: CSS clip should not be considered when clamping for overflow clip. (Closed)

Created:
7 years, 6 months ago by shawnsingh
Modified:
7 years, 6 months ago
Reviewers:
esprehn
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

CSS clip should not be considered when clamping for overflow clip. Previous patch in webkit rev 152919 partially fixed this, but skipped one code path that still needed fixing. These code paths are intended to clamp the backgroundRect to the borderBox, or a slightly inflated borderBox. It is incorrect to trigger those code paths when there is only CSS clip and no overflow clip. Fixing this bug also results in a tiny refactor where the CSS clip if-statement is separated from the overflow clip chunks of code. BUG=246728 R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
A + LayoutTests/compositing/geometry/clip-with-shadow.html View 5 chunks +16 lines, -8 lines 0 comments Download
A + LayoutTests/compositing/geometry/clip-with-shadow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 3 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
shawnsingh
PTAL, thanks very much! Still running tests, but I am optimistic they will pass. It ...
7 years, 6 months ago (2013-06-25 01:26:46 UTC) #1
esprehn
LGTM. Thanks for adding some comments too!
7 years, 6 months ago (2013-06-25 01:34:07 UTC) #2
shawnsingh
7 years, 6 months ago (2013-06-25 03:45:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r152980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698